Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qfile-agent: fix CLI progress display unit mismatch #509

Merged
merged 2 commits into from
Jul 5, 2024
Merged

qfile-agent: fix CLI progress display unit mismatch #509

merged 2 commits into from
Jul 5, 2024

Commits on Jun 27, 2024

  1. qfile-agent: rename a variable

    @rustybird
    rustybird committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2b7b10a View commit details
    Browse the repository at this point in the history

  2. qfile-agent: fix CLI progress display unit mismatch 

    qubes-fs-tree-check outputs the total estimated size in bytes, not KB.

Fix the display bug by renaming the env variable that's used to pass
this number (in the qvm-copy wrapper script) to $FILECOPY_TOTAL_BYTES,
and then making qfile-agent convert from bytes to KB display units.

    $ truncate -s 10K foo
    $ qvm-copy foo  # before:
    sent 10/10240 KB
    $ qvm-copy foo  # after:
    sent 10/10 KB
    @rustybird
    rustybird committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ca6e96d View commit details
    Browse the repository at this point in the history