Implement admin.backup.* methods #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useless here since backup restore is moved to qubes-core-admin-client.
Do not assume static list of volume (although it is true for now), and also use proper API for getting volume size, instead of assuming it's a normal file.
Those tests are only about Admin API integration, not about actual backup backend code QubesOS/qubes-issues#2931
If inner tar returns with non-zero code, mostly like the backup is incomplete, so it is very important to report it.
Since we have LVM by default, it is possible to backup VMs while they are running. For now it will include its state from before startup, but later we may implement some other logic (a snapshot of running VM).
The old format have many issues and is discouraged by tar developers. In this case the most important one is header with possible non-ASCII characters, which will result in UnicodeDecodeError (tarfile module require header parts in utf-8). PAX format is much cleaner, as it use standard mechanism for extended headers.
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 49.12% 51.11% +1.99%
==========================================
Files 53 53
Lines 7976 8019 +43
==========================================
+ Hits 3918 4099 +181
+ Misses 4058 3920 -138
Continue to review full report at Codecov.
|
When passphrase is retrieved from VM, it is already encoded. Do not try to encode it again. QubesOS/qubes-issues#2931
…s called In some cases (even manual manipulation) those files may not be present - especially because thin snapshots do not have nodes in /dev by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is core-admin part of QubesOS/qubes-issues#2931
Plus few related fixes.