Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func ClaudeMessagesRequestToOpenAIChat(claudeRequest dto.ClaudeRequest, info con
if len(toolCalls) > 0 {
openAIMessage.SetToolCalls(toolCalls)
}
if len(mediaMessages) > 0 && len(toolCalls) == 0 {
if len(mediaMessages) > 0 {
openAIMessage.SetMediaContent(mediaMessages)
}
}
Expand Down
80 changes: 80 additions & 0 deletions relaykit/relayconvert/request_registry_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package relayconvert

import (
"context"
"testing"

"github.com/QuantumNous/new-api/relaykit/dto"
Expand All @@ -12,6 +13,85 @@ import (
"github.com/stretchr/testify/require"
)

func TestClaudeMessagesToOpenAIChatPreservesAssistantTextWithToolCalls(t *testing.T) {
text := "I will look that up."
request := dto.ClaudeRequest{
Model: "claude-test",
Messages: []dto.ClaudeMessage{
{
Role: "assistant",
Content: []dto.ClaudeMediaMessage{
{Type: "text", Text: &text},
{
Type: "tool_use",
Id: "call_1",
Name: "lookup",
Input: map[string]any{"query": "weather"},
},
},
},
},
}

result, err := ConvertRequest(
context.Background(),
&convmeta.Values{},
types.RelayFormatOpenAI,
&request,
)
require.NoError(t, err)

converted, ok := result.Value.(*dto.GeneralOpenAIRequest)
require.True(t, ok)
require.Len(t, converted.Messages, 1)

assistant := converted.Messages[0]
assert.Equal(t, "assistant", assistant.Role)
toolCalls := assistant.ParseToolCalls()
require.Len(t, toolCalls, 1)
assert.Equal(t, "call_1", toolCalls[0].ID)
require.Len(t, assistant.ParseContent(), 1)
assert.Equal(t, "text", assistant.ParseContent()[0].Type)
assert.Equal(t, text, assistant.ParseContent()[0].Text)
}

func TestClaudeMessagesToOpenAIChatKeepsToolOnlyContentEmpty(t *testing.T) {
request := dto.ClaudeRequest{
Model: "claude-test",
Messages: []dto.ClaudeMessage{
{
Role: "assistant",
Content: []dto.ClaudeMediaMessage{
{
Type: "tool_use",
Id: "call_1",
Name: "lookup",
Input: map[string]any{"query": "weather"},
},
},
},
},
}

result, err := ConvertRequest(
context.Background(),
&convmeta.Values{},
types.RelayFormatOpenAI,
&request,
)
require.NoError(t, err)

converted, ok := result.Value.(*dto.GeneralOpenAIRequest)
require.True(t, ok)
require.Len(t, converted.Messages, 1)

assistant := converted.Messages[0]
assert.Empty(t, assistant.ParseContent())
toolCalls := assistant.ParseToolCalls()
require.Len(t, toolCalls, 1)
assert.Equal(t, "call_1", toolCalls[0].ID)
}

func TestRequestConverterRegistryListsSupportedTextConverters(t *testing.T) {
tests := []struct {
converter string
Expand Down