fix(keys): restore auto group badge and guard cross-group badge - #6809
fix(keys): restore auto group badge and guard cross-group badge#6809zkasuran wants to merge 1 commit into
Conversation
The auto group cell rendered the Cross-group badge unconditionally and left AutoGroupBadge commented out, so auto keys lost their group badge and every auto key claimed cross-group retry. Re-enable AutoGroupBadge and gate the Cross-group badge on the per-key crossGroupRetry flag, matching the backend semantics and the cell's committed test. Closes QuantumNous#6804
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe API key group cell now renders ChangesAPI key group badge rendering
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This restores the correct badges for auto keys and gates the Cross-group badge by its state, with no actionable merge-blocking risk remaining after normal checks and review. Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
51fdfc5 to
2b6f1df
Compare
Important
📝 变更描述 / Description
The Group column cell for
autokeys on/keyswas showing theCross-groupbadge on every auto key and no longer showing the badge that marks the key as
auto. A previous "temporarily disable AutoGroupBadge" refactor commented out<AutoGroupBadge />and, in the same hunk, dropped thecrossGroupRetryguardaround the
Cross-groupbadge, so the badge stopped reflecting each key'scross_group_retrystate and auto keys with no ratio data ended up with anempty-looking group cell.
This restores the two removed lines in
api-key-group-cell.tsx: it rendersAutoGroupBadgeagain and wraps theCross-groupStatusBadgein{props.crossGroupRetry && ...}.crossGroupRetrywas already declared on theprops and passed from
api-keys-columns.tsx, it just was not read. This matchesthe per-token backend semantics (
Token.CrossGroupRetry, read inservice/channel_select.go, forced false for non-auto groups incontroller/token.go) and turns the component's own committed test file green(it asserts two Auto frames when a ratio is present and one when it is not, plus
that
Cross-grouponly appears with the flag on). Scope is this one cell.🚀 变更类型 / Type of change
🔗 关联任务 / Related Issue
✅ 提交前检查项 / Checklist
Bug fix,我已提交或关联对应 Issue,且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。📸 运行证明 / Proof of Work
Ran from
web/:Summary by CodeRabbit