fix: test Claude/Gemini endpoints with native request format by seefs001 · Pull Request #6698 · QuantumNous/new-api

seefs001 · 2026-08-07T05:19:10Z

⚠️ 提交说明 / PR Notice

Important

请提供人工撰写的简洁摘要，避免直接粘贴未经整理的 AI 输出。

📝 变更描述 / Description

(简述：做了什么？为什么这样改能生效？请基于你对代码逻辑的理解来写，避免粘贴未经整理的内容)

修正渠道测试请求路径，避免 Anthropic渠道走转换。

🚀 变更类型 / Type of change

🐛 Bug 修复 (Bug fix) - 请关联对应 Issue，避免将设计取舍、理解偏差或预期不一致直接归类为 bug
✨ 新功能 (New feature) - 重大特性建议先通过 Issue 沟通
⚡ 性能优化 / 重构 (Refactor)
📝 文档更新 (Documentation)

🔗 关联任务 / Related Issue

Closes Bug: Advanced Custom渠道测试连接选择 /v1/messages 端点时构造 OpenAI chat 请求体，导致 Anthropic→OpenAI Chat 转换器报错 (convert_request_failed) #6689

✅ 提交前检查项 / Checklist

人工确认: 我已亲自整理并撰写此描述，没有直接粘贴未经处理的 AI 输出。
非重复提交: 我已搜索现有的 Issues 与 PRs，确认不是重复提交。
Bug fix 说明: 若此 PR 标记为 Bug fix，我已提交或关联对应 Issue，且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。
变更理解: 我已理解这些更改的工作原理及可能影响。
范围聚焦: 本 PR 未包含任何与当前任务无关的代码改动。
本地验证: 已在本地运行并通过测试或手动验证，维护者可以据此复核结果。
安全合规: 代码中无敏感凭据，且符合项目代码规范。

📸 运行证明 / Proof of Work

(请在此粘贴截图、关键日志或测试报告，以证明变更生效)

Summary by CodeRabbit

Improvements
- Improved streaming request handling for Gemini.
- Expanded compatibility with Claude, Gemini, and OpenAI request formats.
- Updated endpoint-specific request validation and error messaging for clearer feedback.
- Preserved OpenAI request behavior while correcting token limit handling in relevant test scenarios.

coderabbitai · 2026-08-07T05:19:39Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 79c55afc-5ef3-43d1-9e62-9be74cfba2e5

📥 Commits

Reviewing files that changed from the base of the PR and between 0cd9dc8 and 9a04217.

📒 Files selected for processing (1)

controller/channel-test.go

Walkthrough

Channel tests now build native Claude and Gemini requests, retain OpenAI requests with a fixed token limit, select Gemini’s streaming endpoint, and dispatch each request type through its matching conversion method.

Changes

Channel test request alignment

Layer / File(s)	Summary
Endpoint-specific request construction `controller/channel-test.go`	Streaming Gemini tests use `:streamGenerateContent`. Claude and Gemini tests construct native request DTOs. OpenAI tests retain `GeneralOpenAIRequest` with `MaxTokens` set to 16.
Provider request conversion `controller/channel-test.go`	The default conversion branch dispatches `GeneralOpenAIRequest`, `ClaudeRequest`, and `GeminiChatRequest` to their respective adaptor methods. Unsupported inputs return a generic chat request type error.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: calcium-ion

Poem

A rabbit checks each channel’s flight,
Claude and Gemini now fit just right.
OpenAI keeps tokens sixteen,
Stream paths point where streams are seen.
The test hops on, request types clear.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes testing Claude and Gemini endpoints with their native request formats.
Linked Issues check	✅ Passed	The changes construct native Claude and Gemini requests and use endpoint-specific streaming actions, satisfying issue `#6689` objectives.
Out of Scope Changes check	✅ Passed	The summarized changes remain within channel test request construction and conversion handling described in issue `#6689`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Brings in from QuantumNous/new-api: - fix: 修复兑换码额度精度损失 (QuantumNous#6685) - feat(rate-limit): user critical rate limit for access token and aff transfer routes - fix: test Claude/Gemini endpoints with native request format (QuantumNous#6698) - feat(channels): refine fetched model categorization (QuantumNous#6632) - security: atomic access-token rotation and aff updates (merge commit from fork) - refactor(relay): move replay metadata onto request bodies - fix(relay): set Request.GetBody for transparent HTTP/2 retry (QuantumNous#6249) - Feat/auto group (QuantumNous#6590) - fix(aws): cancel Bedrock requests on client disconnect (QuantumNous#6589) Conflicts resolved: - controller/model.go: adopt upstream's unified group-model loop with FormatMatchingModelName token-limit matching; keep fork's hiddenMappedModels filter inside the loop - model/user.go: keep fork's BatchDeleteUsers; adopt upstream's atomic gorm.Expr-based inviteUser - relay/channel/task/sora/adaptor_test.go: keep both fork's New API Video channel tests and upstream's replayable-body test Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ZteapnbTWdP52n7wZ6NsN

…Nous#6698)

- fix(relay): set Request.GetBody so HTTP/2 can transparently retry after upstream stream reset (QuantumNous#6249) - refactor(relay): move replay metadata onto request bodies (适配 fork: 保留 types.PriceData) - feat(channels): refine fetched model categorization (QuantumNous#6632) - fix: test Claude/Gemini endpoints with native request format (QuantumNous#6698) - feat(rate-limit): add user critical rate limit middleware (access-token / aff-transfer 路由) - fix: 修复兑换码额度精度损失 (QuantumNous#6685) (保留 fork 随机额度/下载/100000 批量特性) 跳过: relaykit 模块重构系列(86ac0f7 等, 按 fork 策略), GitCode 发布 CI 工作流, 已同步的 24 个 cherry-pick 副本

* fix(relay): set Request.GetBody so the HTTP/2 transport can transparently retry after an upstream stream reset (QuantumNous#6249) * fix(relay): set Request.GetBody so the HTTP/2 transport can transparently retry after an upstream stream reset The outbound request body is a type-erased io.Reader over BodyStorage, so net/http cannot derive Request.GetBody (it only does so for *bytes.Reader, *bytes.Buffer and *strings.Reader). With GetBody nil, the HTTP/2 transport cannot transparently retry a request once the body has been written and the upstream resets the stream with a retryable error (REFUSED_STREAM, or a connection-level GOAWAY); the relay request then fails with: http2: Transport: cannot retry err [...] after Request.Body was written; define Request.GetBody to avoid this error This affects every relay path that goes through DoApiRequest (chat, claude, gemini, responses, embedding, image, rerank). BodyStorage (memory and disk) already implements io.Seeker, so replay support only needed wiring: - NewOutboundJSONBody additionally returns a getBody that rewinds the storage and hands out a fresh non-closing reader. The transport only calls GetBody after the previous attempt's body has been abandoned, so the rewind cannot race an in-flight read. - RelayInfo carries it in the new UpstreamRequestGetBody field, set alongside UpstreamRequestBodySize by the handlers that build storage-backed bodies. - applyUpstreamGetBody (symmetric with applyUpstreamContentLength) wires it into DoApiRequest/DoFormRequest/DoTaskApiRequest, only when req.GetBody is still nil. Also remove the hand-rolled GetBody override in DoTaskApiRequest: it returned the same already-consumed reader, so any transport-level replay would have silently sent an empty body, and it clobbered the correct snapshot-based GetBody that net/http derives from the *bytes.Reader bodies the task adaptors pass in. For non-replayable bodies GetBody now stays nil, so a retry fails loudly instead of corrupting the request. Covered by unit tests plus an end-to-end raw-frame HTTP/2 test that resets the first stream with REFUSED_STREAM after the body is written and asserts the transport transparently retries with the complete body. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(relay): hand out independent readers from GetBody (address review) Per the http.Request.GetBody contract ("returns a new copy of Body"), each call must yield a reader with its own cursor. The previous implementation rewound and reused the shared BodyStorage, so two consecutive GetBody readers would interfere with each other, and a replay could disturb the primary body's offset under extreme transport timing (e.g. attempt N's body write not yet fully abandoned when the transport builds attempt N+1). Instead of snapshotting the payload (an extra copy), add BodyStorage.NewReader, which returns an independent zero-copy reader: - memory mode: a fresh bytes.Reader over the same immutable backing array; - disk mode: a separate file descriptor over the cache file, so the transport closing a replayed body only closes that descriptor. NewOutboundJSONBody's getBody now simply hands out storage.NewReader, and once the handler releases the storage, GetBody fails with ErrStorageClosed instead of replaying stale data. Tests: interleaved reads across two replay readers and the primary body each observe exactly their own byte stream, for both the memory and the disk-backed storage; the existing GetBody and HTTP/2 retry suites still pass (h2 e2e tests flake-free with -count=20). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(relay): bind replayable metadata on pass-through requests * fix(relay): reset upstream body metadata between channels * test(relay): cover replay across retries and channel attempts * fix(relay): stop following upstream redirects --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * refactor(relay): move replay metadata onto request bodies * Merge commit from fork * feat(channels): refine fetched model categorization (QuantumNous#6632) * feat(channels): refine fetched model categorization * fix: channel category * fix: hy3 category * fix: test Claude/Gemini endpoints with native request format (QuantumNous#6698) * feat(rate-limit): add user critical rate limit middleware for access token and aff transfer routes * fix: 修复兑换码额度精度损失 (QuantumNous#6685) * fix: 修复兑换码额度精度损失(QuantumNous#6680) * fix(redemption): guard update data integrity * CI: enhance release synchronization workflow with optional file syncing * fix(ali): stop injecting top_p into requests that omit it (QuantumNous#6674) * fix(channels): classify Qwen TTS models correctly (QuantumNous#6711) * feat(channels): add auto-disable-only channel test mode (QuantumNous#6728) * perf(web): debounce server and large-list searches (QuantumNous#6727) * fix: record reasoning effort consistently in usage logs (QuantumNous#6641) * feat(relay): expose user and group context to parameter overrides (QuantumNous#6534) * fix(ollama): preserve reasoning and tool-call context (QuantumNous#6605) * fix: backend length validation (QuantumNous#5548) * feat(billing): highlight matched conditional multipliers in logs (QuantumNous#6561) * feat(billing): highlight matched conditional multipliers in usage logs * fix(billing): make request rule tracing stable and type-safe * fix(web): require confirmation before rotating access token (QuantumNous#6749) --------- Co-authored-by: Lucas <hepo.lucas@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: CaIon <i@caion.me> Co-authored-by: RedwindA <128586631+RedwindA@users.noreply.github.com> Co-authored-by: Seefs <40468931+seefs001@users.noreply.github.com> Co-authored-by: lihu-001 <lihu9048@gmail.com> Co-authored-by: ENCHIGO <38551565+ENCHIGO@users.noreply.github.com>

…Nous#6698)

…Nous#6698) (cherry picked from commit b941253)

* v1.0.0-rc.24: (117 commits) CI: enhance release synchronization workflow with optional file syncing fix: 修复兑换码额度精度损失 (QuantumNous#6685) feat(rate-limit): add user critical rate limit middleware for access token and aff transfer routes fix: test Claude/Gemini endpoints with native request format (QuantumNous#6698) feat(channels): refine fetched model categorization (QuantumNous#6632) Merge commit from fork refactor(relay): move replay metadata onto request bodies fix(relay): set Request.GetBody so the HTTP/2 transport can transparently retry after an upstream stream reset (QuantumNous#6249) Feat/auto group (QuantumNous#6590) fix(aws): cancel Bedrock requests on client disconnect (QuantumNous#6589) fix(billing): harden tiered retry group-switch billing (QuantumNous#6570) fix(billing): settle tiered retries with final group (QuantumNous#6518) feat: deepseek responses api (QuantumNous#6562) style: use text-sm for public header nav links to match other nav components (QuantumNous#6557) fix(oauth): stop treating a foreign window.opener as a bind flow (QuantumNous#6425) fix(relay): preserve multipart image edits for New API channels (QuantumNous#6559) feat(logs): expose stream status to log owners (QuantumNous#6558) feat: support zstd request decompression (QuantumNous#6545) fix: preserve Qwen thinking_budget passthrough (QuantumNous#5836) feat(oidc): 支持自定义 OIDC 登录显示名称 (QuantumNous#6012) ... # Conflicts: # service/text_quota.go # web/src/features/models/components/drawers/model-mutate-drawer.tsx # web/src/features/pricing/components/model-details.tsx # web/src/features/pricing/lib/price.ts

…Nous#6698)

fix: test Claude/Gemini endpoints with their native request formats

9a04217

seefs001 merged commit b941253 into QuantumNous:main Aug 7, 2026
3 of 4 checks passed

0401lucky pushed a commit to 0401lucky/new-api that referenced this pull request Aug 7, 2026

fix: test Claude/Gemini endpoints with native request format (Quantum…

6c13c89

…Nous#6698)

henrymartin262 pushed a commit to henrymartin262/new-api that referenced this pull request Aug 12, 2026

fix: test Claude/Gemini endpoints with native request format (Quantum…

ff6f62f

…Nous#6698)

coderabbitai Bot mentioned this pull request Aug 13, 2026

fix(vertex): convert Anthropic Messages to Gemini for Gemini upstreams #6812

Draft

11 tasks

2hot4you pushed a commit to 2hot4you/new-api that referenced this pull request Aug 13, 2026

fix: test Claude/Gemini endpoints with native request format (Quantum…

bbc2754

…Nous#6698) (cherry picked from commit b941253)

zcxads666 mentioned this pull request Aug 14, 2026

fix(relay): stop injecting empty tools into Claude requests that omit them #6837

Merged

11 tasks

DayFliggy pushed a commit to DayFliggy/Ren2Hub that referenced this pull request Aug 17, 2026

fix: test Claude/Gemini endpoints with native request format (Quantum…

586aa38

…Nous#6698)

330079598 pushed a commit to 330079598/new-api that referenced this pull request Aug 19, 2026

fix: test Claude/Gemini endpoints with native request format (Quantum…

3345505

…Nous#6698)

Navigation Menu

Uh oh!

fix: test Claude/Gemini endpoints with native request format - #6698

fix: test Claude/Gemini endpoints with native request format#6698
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/advanced-custom-channel-test

seefs001 commented Aug 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seefs001 commented Aug 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ 提交说明 / PR Notice

📝 变更描述 / Description

🚀 变更类型 / Type of change

🔗 关联任务 / Related Issue

✅ 提交前检查项 / Checklist

📸 运行证明 / Proof of Work

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seefs001 commented Aug 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 7, 2026 •

edited

Loading