fix(users): prevent large quota values from overflowing - #6134
Merged
Conversation
- widen the quota column and add consistent spacing between remaining and total values. - extract quota rendering into a dedicated component and truncate oversized text within the cell. - preserve full-value tooltips, progress indicators, and the zero-quota state.
Contributor
WalkthroughChangesUser quota display
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JacksonsY
added a commit
to JacksonsY/new-api
that referenced
this pull request
Jul 15, 2026
上游 7c28993..a63364d： - fix: purge authentication data on hard user deletion (QuantumNous#6168) —— 硬删用户时清理 2FA/备份码/Passkey/Token/OAuth 绑定 + 缓存失效（安全修复，跟上游）。后端文件 (model/user.go、token.go、twofa.go、controller/user.go、telegram.go) 自动合并为 并集：上游清理逻辑 + fork 供应商字段/隐藏敏感字段均完整保留（逐文件校验新增行数与 上游一致）。 - fix: infer MiniMax vendor for MiniMax models (QuantumNous#6164) —— 常规修复，跟上游。 - fix(users): prevent large quota values from overflowing (QuantumNous#6134) —— 纯前端「单元格文本 溢出」的显示修复（非整数溢出）。冲突文件 users-columns.tsx 按「界面归我们」保留 fork 版 （语义色 token bg-destructive/warning/success + StatusBadge children API + 卡片式 meta cardRole/cardSpan/contentMode），未采用上游抽出的 user-quota-cell.tsx（其用 base 时代的硬编码色/label API，与 fork 设计系统已分叉），该新组件在本合并中删除。 go build ./... 通过；model/controller 测试（含上游新增 user_authentication/telegram/ task_cas 测试）全绿；前端树与 fork HEAD 等价。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fux-dev
pushed a commit
to fux-dev/new-api
that referenced
this pull request
Jul 19, 2026
…6134) - widen the quota column and add consistent spacing between remaining and total values. - extract quota rendering into a dedicated component and truncate oversized text within the cell. - preserve full-value tooltips, progress indicators, and the zero-quota state.
jiweiyeah
added a commit
to jiweiyeah/yutou-api
that referenced
this pull request
Jul 25, 2026
Synced upstream/main (8739c05 → 5a6c53d, 49 commits) into custom. Conflicts resolved by keeping custom side per user instruction: - controller/user.go: kept custom subscription filter + total_topup sort - model/user.go: kept custom queryUsers delegation (GetAllUsers/GetAllUsersFiltered/SearchUsers) - model/channel_cache.go: kept custom performance monitoring (RecordCacheSync) - web/default/src/features/users/components/users-columns.tsx: kept custom imports (formatNumber, cn) - web/default/src/features/users/components/users-table.tsx: kept custom controlled sorting + server-side ordering + subscriptionFilter Removed upstream test model/user_pagination_test.go — depends on the upstream sortOptions-based GetAllUsers/SearchUsers signatures that custom side does not expose (custom uses queryUsers with subStatus/orderBy/orderDir). Verified: go build ./... and web/default tsc --noEmit both pass. Notable upstream fixes absorbed: - QuantumNous#6225 prevent duplicate tool calls in Responses→Chat streaming - QuantumNous#6194 server-side sorting for user list (fix paged-data client-sort bug) - QuantumNous#6134 prevent large quota values from overflowing - QuantumNous#6168 purge authentication data on hard user deletion - QuantumNous#6096 golang.org/x/crypto 0.51.0 → 0.52.0 - Deadlock fix in channel_cache.go (InvalidatePricingCache lock ordering) NOT absorbed — custom side keeps performance monitoring branch. Manual review needed if pricing cache staleness is observed.
zhaodechao2008
pushed a commit
to zhaodechao2008/new-api
that referenced
this pull request
Jul 27, 2026
…6134) - widen the quota column and add consistent spacing between remaining and total values. - extract quota rendering into a dedicated component and truncate oversized text within the cell. - preserve full-value tooltips, progress indicators, and the zero-quota state.
MinTiang
pushed a commit
to MinTiang/new-api
that referenced
this pull request
Aug 6, 2026
…6134) - widen the quota column and add consistent spacing between remaining and total values. - extract quota rendering into a dedicated component and truncate oversized text within the cell. - preserve full-value tooltips, progress indicators, and the zero-quota state.
330079598
pushed a commit
to 330079598/new-api
that referenced
this pull request
Aug 19, 2026
…6134) - widen the quota column and add consistent spacing between remaining and total values. - extract quota rendering into a dedicated component and truncate oversized text within the cell. - preserve full-value tooltips, progress indicators, and the zero-quota state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
📝 变更描述 / Description
问题描述
修复方式
UserQuotaCell组件。测试说明
🚀 变更类型 / Type of change
🔗 关联任务 / Related Issue
✅ 提交前检查项 / Checklist
Bug fix，我已提交或关联对应 Issue，且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。📸 运行证明 / Proof of Work
bunx oxfmt --check src/features/users/components/users-columns.tsx src/features/users/components/user-quota-cell.tsxbunx oxlint -c .oxlintrc.json src/features/users/components/users-columns.tsx src/features/users/components/user-quota-cell.tsxbun run typecheckbun run buildSummary by CodeRabbit