Skip to content

Fix/build date dns error - #5945

Merged
Calcium-Ion merged 2 commits into
QuantumNous:mainfrom
seefs001:fix/build-date-dns-error
Jul 6, 2026
Merged

Fix/build date dns error#5945
Calcium-Ion merged 2 commits into
QuantumNous:mainfrom
seefs001:fix/build-date-dns-error

Conversation

@seefs001

@seefs001 seefs001 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

⚠️ 提交说明 / PR Notice

Important

  • 请提供人工撰写的简洁摘要,避免直接粘贴未经整理的 AI 输出。

📝 变更描述 / Description

(简述:做了什么?为什么这样改能生效?请基于你对代码逻辑的理解来写,避免粘贴未经整理的内容)

🚀 变更类型 / Type of change

  • 🐛 Bug 修复 (Bug fix) - 请关联对应 Issue,避免将设计取舍、理解偏差或预期不一致直接归类为 bug
  • ✨ 新功能 (New feature) - 重大特性建议先通过 Issue 沟通
  • ⚡ 性能优化 / 重构 (Refactor)
  • 📝 文档更新 (Documentation)

🔗 关联任务 / Related Issue

  • Closes # (如有)

✅ 提交前检查项 / Checklist

  • 人工确认: 我已亲自整理并撰写此描述,没有直接粘贴未经处理的 AI 输出。
  • 非重复提交: 我已搜索现有的 IssuesPRs,确认不是重复提交。
  • Bug fix 说明: 若此 PR 标记为 Bug fix,我已提交或关联对应 Issue,且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。
  • 变更理解: 我已理解这些更改的工作原理及可能影响。
  • 范围聚焦: 本 PR 未包含任何与当前任务无关的代码改动。
  • 本地验证: 已在本地运行并通过测试或手动验证,维护者可以据此复核结果。
  • 安全合规: 代码中无敏感凭据,且符合项目代码规范。

📸 运行证明 / Proof of Work

(请在此粘贴截图、关键日志或测试报告,以证明变更生效)

Summary by CodeRabbit

  • Bug Fixes
    • Updated app dependency resolution so date handling now uses the standard package path instead of a redirected location.
    • This should help avoid build or runtime issues caused by conflicting date library resolution.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 11817d32-eba8-4081-8704-d28373b5c2b9

📥 Commits

Reviewing files that changed from the base of the PR and between 153d7f0 and 75f9acb.

📒 Files selected for processing (1)
  • web/classic/rsbuild.config.ts
💤 Files with no reviewable changes (1)
  • web/classic/rsbuild.config.ts

Walkthrough

The Rsbuild configuration for the classic web app removes the semiDateFnsDir path constant and its corresponding resolve.alias entry that redirected date-fns imports to semi-foundation's bundled copy.

Changes

Rsbuild date-fns alias removal

Layer / File(s) Summary
Remove date-fns path resolution and alias
web/classic/rsbuild.config.ts
Removes the semiDateFnsDir constant computed from semiUiDir and deletes the date-fns entry from resolve.alias, leaving only the semi.css alias.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • QuantumNous/new-api#5892: Originally added the semiDateFnsDir and date-fns alias in the same config file that this PR removes.

Poem

A little alias hopped away,
No more redirects, come what may,
date-fns finds its own true path,
No semi-foundation aftermath,
Thump-thump, the config's clean today! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the build fix and points to the date-fns error addressed by the config change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Calcium-Ion
Calcium-Ion merged commit 45f0484 into QuantumNous:main Jul 6, 2026
2 checks passed
@seefs001 seefs001 linked an issue Jul 6, 2026 that may be closed by this pull request
4 tasks
JacksonsY added a commit to JacksonsY/new-api that referenced this pull request Jul 7, 2026
Upstream: build-date DNS fix (QuantumNous#5945) + billing quantity validation and
int32-saturating quota conversions.

Conflicts resolved:
- pkg/billingexpr/round.go: took upstream. QuotaRound now saturates at int32
  bounds (DB quota columns are 32-bit), guarding against an oversized result
  wrapping a charge into a credit. Fork side was only an older int-range clamp.
- web/classic/rsbuild.config.ts: kept fork version. The date-fns alias is an
  intentional fork build fix for `bun install --filter ./classic` (CI/Docker);
  upstream merely deleted its own simpler variant and shipped no dep-level
  replacement, so dropping it would risk the fork's classic build.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
52assert added a commit to 52assert/new-api that referenced this pull request Jul 7, 2026
…codes

* origin/main: (180 commits)
  fix(billing): extend quantity validation and saturating conversions to remaining paths
  fix(billing): validate quantity parameters and harden quota calculations
  Fix/build date dns error (QuantumNous#5945)
  fix: avoid stale stream writes after client disconnect (QuantumNous#5710)
  feat(group): enhance group ratio editor with improved visibility rules and JSON parsing
  feat: optimize legacy top-up warning banner copy (QuantumNous#5851) (QuantumNous#5855)
  fix(web): redirect authenticated users away from sign-up page (QuantumNous#5910)
  feat(ssrf): implement SSRF protection in HTTP clients and validation functions
  feat(user): better messages for redeem failures
  fix(html): 修复 Shadow DOM 隔离渲染下深浅色模式无法自动切换的问题 (QuantumNous#5890)
  fix(web): sync home iframe theme and language (QuantumNous#5917)
  fix: 任务差额结算后 quota 和阿里视频时长优化 (QuantumNous#5923)
  fix(web): refine mobile user cards
  test(user): cover self-service password update guard
  feat(session): support opt-in Secure session cookies
  fix(auth): allow read-only access for non-disabled tokens
  fix(user): harden account email and password handling
  fix: align dynamic pricing style with log details dialog sections
  fix(channels): show field passthrough controls for Codex (QuantumNous#5902)
  fix(user): trim whitespace from username and validate input
  ...

# Conflicts:
#	controller/redemption.go
#	controller/user.go
#	model/option.go
#	model/redemption.go
#	model/user.go
#	web/default/src/features/auth/api.ts
#	web/default/src/features/redemption-codes/api.ts
#	web/default/src/features/redemption-codes/components/redemptions-provider.tsx
#	web/default/src/features/redemption-codes/components/redemptions-table.tsx
#	web/default/src/features/redemption-codes/constants.ts
#	web/default/src/hooks/use-sidebar-data.ts
#	web/default/src/i18n/static-keys.ts
#	web/default/src/routes/__root.tsx
@coderabbitai coderabbitai Bot mentioned this pull request Jul 7, 2026
11 tasks
LibraScorpion pushed a commit to LibraScorpion/new-api-nexusroute that referenced this pull request Jul 8, 2026
* Revert "fix(classic): fix classic web build failures"

This reverts commit 997926b.

* fix(classic): use available Slack icon export
xiaomingchen pushed a commit to xiaomingchen/new-api that referenced this pull request Jul 10, 2026
* Revert "fix(classic): fix classic web build failures"

This reverts commit 997926b.

* fix(classic): use available Slack icon export
Jacobinwwey pushed a commit to Jacobinwwey/new-api that referenced this pull request Jul 11, 2026
* Revert "fix(classic): fix classic web build failures"

This reverts commit 7e63681.

* fix(classic): use available Slack icon export
ruanhangjian pushed a commit to ruanhangjian/new-api that referenced this pull request Jul 11, 2026
* Revert "fix(classic): fix classic web build failures"

This reverts commit 997926b.

* fix(classic): use available Slack icon export
lizhongyi1209 pushed a commit to lizhongyi1209/new-api that referenced this pull request Jul 13, 2026
* Revert "fix(classic): fix classic web build failures"

This reverts commit 997926b.

* fix(classic): use available Slack icon export

(cherry picked from commit 45f0484)
@coderabbitai coderabbitai Bot mentioned this pull request Jul 19, 2026
11 tasks
zhaodechao2008 pushed a commit to zhaodechao2008/new-api that referenced this pull request Jul 27, 2026
* Revert "fix(classic): fix classic web build failures"

This reverts commit e80b1ed.

* fix(classic): use available Slack icon export
330079598 pushed a commit to 330079598/new-api that referenced this pull request Aug 19, 2026
* Revert "fix(classic): fix classic web build failures"

This reverts commit 997926b.

* fix(classic): use available Slack icon export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

通过源码构建报错

2 participants