Skip to content

fix: only fetch deployment settings on deployments page #5466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seefs001 merged 1 commit into from
Jun 12, 2026
Merged

fix: only fetch deployment settings on deployments page #5466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 40 additions & 47 deletions web/default/src/features/models/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ const SECTION_META: Record<ModelsSectionId, { titleKey: string }> = {
function ModelsContent() {
const { t } = useTranslation()
const navigate = useNavigate()
const queryClient = useQueryClient()
const { tabCategory, setTabCategory } = useModels()
const params = route.useParams()
const activeSection = (params.section ??
Expand All @@ -70,41 +69,6 @@ function ModelsContent() {
}
}, [activeSection, setTabCategory, tabCategory])

const {
loading: deploymentLoading,
loadingPhase,
isIoNetEnabled,
connectionLoading,
connectionOk,
connectionError,
testConnection,
refresh: refreshDeploymentSettings,
} = useModelDeploymentSettings()

// Ensure settings are fresh when switching to deployments section
useEffect(() => {
if (activeSection === 'deployments') {
refreshDeploymentSettings()
}
}, [activeSection, refreshDeploymentSettings])

// Prefetch deployments list while connection check is in progress
// This allows the data to be ready as soon as the guard passes
useEffect(() => {
if (
activeSection === 'deployments' &&
isIoNetEnabled &&
loadingPhase === 'connection'
) {
const defaultParams = { p: 1, page_size: 10 }
queryClient.prefetchQuery({
queryKey: deploymentsQueryKeys.list(defaultParams),
queryFn: () => listDeployments(defaultParams),
staleTime: 30 * 1000, // 30 seconds
})
}
}, [activeSection, isIoNetEnabled, loadingPhase, queryClient])

const handleSectionChange = useCallback(
(section: string) => {
void navigate({
Expand Down Expand Up @@ -146,17 +110,7 @@ function ModelsContent() {
{activeSection === 'metadata' ? (
<ModelsTable />
) : (
<DeploymentAccessGuard
loading={deploymentLoading}
loadingPhase={loadingPhase}
isEnabled={isIoNetEnabled}
connectionLoading={connectionLoading}
connectionOk={connectionOk}
connectionError={connectionError}
onRetry={testConnection}
>
<DeploymentsTable />
</DeploymentAccessGuard>
<DeploymentsSection />
)}
</div>
</div>
Expand All @@ -172,6 +126,45 @@ function ModelsContent() {
)
}

function DeploymentsSection() {
const queryClient = useQueryClient()
const {
loading: deploymentLoading,
loadingPhase,
isIoNetEnabled,
connectionLoading,
connectionOk,
connectionError,
testConnection,
} = useModelDeploymentSettings()

// Prefetch deployments list while connection check is in progress.
useEffect(() => {
if (isIoNetEnabled && loadingPhase === 'connection') {
const defaultParams = { p: 1, page_size: 10 }
queryClient.prefetchQuery({
queryKey: deploymentsQueryKeys.list(defaultParams),
queryFn: () => listDeployments(defaultParams),
staleTime: 30 * 1000,
})
}
}, [isIoNetEnabled, loadingPhase, queryClient])

return (
<DeploymentAccessGuard
loading={deploymentLoading}
loadingPhase={loadingPhase}
isEnabled={isIoNetEnabled}
connectionLoading={connectionLoading}
connectionOk={connectionOk}
connectionError={connectionError}
onRetry={testConnection}
>
<DeploymentsTable />
</DeploymentAccessGuard>
)
}

export function Models() {
return (
<ModelsProvider>
Expand Down