Skip to content

error - #5385

Closed
461786773 wants to merge 3 commits into
QuantumNous:mainfrom
461786773:cursor/comment-out-docs-links
Closed

error#5385
461786773 wants to merge 3 commits into
QuantumNous:mainfrom
461786773:cursor/comment-out-docs-links

Conversation

@461786773

@461786773 461786773 commented Jun 8, 2026

Copy link
Copy Markdown

PunkCat and others added 3 commits April 30, 2026 13:04
Comment out docs navigation, footer sections, admin settings, and backend docs_link exposure until documentation is re-enabled.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR systematically disables documentation features across the full stack. The backend no longer provides docs_link in API responses or settings. Frontend type definitions and defaults are updated to exclude docs configuration. Document rendering components (PrivacyPolicy, UserAgreement, DocumentRenderer) now return null. Navigation links for documentation are removed from header and sidebar systems. Settings administration forms can no longer configure documentation URLs. Homepage and footer sections lose documentation links and related content.

Changes

Documentation Feature Removal

Layer / File(s) Summary
Backend data model and API response
controller/misc.go, setting/operation_setting/general_setting.go
docs_link field removed from GeneralSetting struct and from GetStatus JSON response payload.
Frontend type definitions and default settings
web/default/src/features/system-settings/types.ts, web/default/src/features/system-settings/maintenance/config.ts, web/default/src/features/system-settings/general/index.tsx
TypeScript GeneralSettings type, HeaderNavPricingConfig type, and default configuration objects no longer include docs_link property.
Document rendering components disabled
web/classic/src/components/common/DocumentRenderer/index.jsx, web/classic/src/pages/PrivacyPolicy/index.jsx, web/classic/src/pages/UserAgreement/index.jsx, web/default/src/features/legal/legal-document.tsx
DocumentRenderer, PrivacyPolicy, and UserAgreement components now return null; LegalDocument removes URL-specific rendering branch and Button/CardContent imports.
Navigation link generation disabled
web/classic/src/hooks/common/useNavigation.js, web/default/src/hooks/use-top-nav-links.ts, change.patch
Default module configs no longer enable docs; docs/about link generation statements commented out in both classic and default theme navigation hooks.
Header state and local storage
web/classic/src/hooks/common/useHeaderBar.js, web/classic/src/helpers/data.js
docsLink hardcoded to empty string; localStorage persistence of docs_link disabled.
Home page and public header UI
web/classic/src/pages/Home/index.jsx, web/default/src/components/layout/components/public-header.tsx, change.patch
Docs button removed from homepage; documentation links filtered from public header navigation and desktop nav rendering.
Settings administration forms and configs
web/classic/src/pages/Setting/Operation/SettingsGeneral.jsx, web/classic/src/pages/Setting/Operation/SettingsHeaderNavModules.jsx, web/default/src/features/system-settings/general/quota-settings-section.tsx, web/default/src/features/system-settings/general/section-registry.tsx, web/default/src/features/system-settings/maintenance/header-navigation-section.tsx, web/classic/src/components/settings/OperationSetting.jsx
Documentation URL field removed from all settings forms; docs module entry removed from header navigation module configuration; schema fields, form mappings, and submit handlers updated across classic and default themes.
Footer and homepage content sections
web/classic/src/components/layout/Footer.jsx, web/default/src/components/layout/components/footer.tsx, web/default/src/features/home/components/sections/stats.tsx.rej, web/default/src/features/home/components/sections/features.tsx, change.patch
Documentation links column removed from footer fallback layout; Stats component rendering disabled; Developer Friendly feature removed from features grid.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • QuantumNous/new-api#1701: Both PRs modify useNavigation and docs link visibility logic—the main PR disables docs link rendering while the retrieved PR extends navigation to use headerNavModules including a docs module, creating a direct overlap in classic theme navigation behavior.

Suggested reviewers

  • Calcium-Ion
  • creamlike1024

Poem

🐰 The docs link fades to null and night,
Comments hide the feature's light,
Navigation clean, no guide in sight,
Footer bare, homepage bright—
A rabbit's work to set it right! 📚✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Cursor/comment out docs links' clearly and specifically describes the main change—disabling documentation links by commenting them out across the codebase.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch cursor/comment-out-docs-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Warning

⚠️ This pull request might be slop. It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

@461786773 461786773 closed this Jun 8, 2026
@461786773
461786773 deleted the cursor/comment-out-docs-links branch June 8, 2026 12:29
@461786773 461786773 changed the title Cursor/comment out docs links error Jun 8, 2026
@461786773
461786773 restored the cursor/comment-out-docs-links branch June 8, 2026 12:41
@461786773
461786773 deleted the cursor/comment-out-docs-links branch June 9, 2026 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant