fix: stop repeated allow_balance_pay column migration on restart

[feitianbubu]

⚠️ 提交说明 / PR Notice

当前 bool类型的列, 如果 default:true
会造成每次启动时, 如果是mysql数据库 migrate会重复报:
model/main.go:304 [60.293ms] [rows:0] ALTER TABLE subscription_plansMODIFY COLUMNallow_balance_pay boolean DEFAULT true
因为mysql的bool默认值是1, true每次会被识别为不匹配

但如果改成 default:1
又会造成如果是postgres数据库 migrate会重复报:
model/main.go:304 [60.293ms] [rows:0] ALTER TABLE subscription_plansMODIFY COLUMNallow_balance_pay boolean DEFAULT 1

目前无论使用哪种默认值, 都无法兼容mysql和pg数据库

🚀 变更类型 / Type of change

最好的方案是去除默认值, 由业务决定默认值,而且这也更符合代码逻辑直觉

✅ 提交前检查项 / Checklist

已检查过,当前AllowBalancePay初始化时, 代码已经默认为true, 因此去除gorm默认值不影响原来的业务逻辑
只会减少每次启动时实际的migrate数据库变动日志噪音

Summary by CodeRabbit

• Refactor
  • Optimized internal default value handling for subscription plan configuration to enhance application logic efficiency.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af0c8eb1-f993-4eca-bdce-0cd5c754b97d

📥 Commits

Reviewing files that changed from the base of the PR and between 4ca47ee and 1800f05.

📒 Files selected for processing (1)

• model/subscription.go

---

Walkthrough

This PR updates the SubscriptionPlan struct in model/subscription.go to remove the database-level gorm:"default:true" tag from the AllowBalancePay *bool field, shifting default initialization from the database schema to application logic via the existing NormalizeDefaults() method.

Changes

GORM Default Tag Migration

Layer / File(s)	Summary
Remove GORM database default from AllowBalancePay model/subscription.go	SubscriptionPlan.AllowBalancePay field tag updated to remove gorm:"default:true", delegating the nil-to-true default behavior to the existing NormalizeDefaults() application method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• QuantumNous/new-api#1393: Removes gorm:"default:..." tags from multiple boolean fields (IsStream, UnlimitedQuota, ModelLimitsEnabled) to shift default initialization to application logic, following the same schema-default tagging pattern.

Suggested reviewers

• seefs001

Poem

🐰 A boolean's home, once the database kept,
Now moves to the code where defaults are swept,
NormalizeDefaults walks in with a smile,
No schema default needed this while,
The change is small but the logic runs deep! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main change: removing a GORM database default that was causing repeated migrations on restart.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}