Skip to content

fix: respect theme for multiselect combobox popover - #5328

Merged
t0ng7u merged 1 commit into
QuantumNous:mainfrom
yyhhyyyyyy:fix/multiselect-popover-theme
Jun 6, 2026
Merged

fix: respect theme for multiselect combobox popover#5328
t0ng7u merged 1 commit into
QuantumNous:mainfrom
yyhhyyyyyy:fix/multiselect-popover-theme

Conversation

@yyhhyyyyyy

@yyhhyyyyyy yyhhyyyyyy commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ 提交说明 / PR Notice

Important

  • 请提供人工撰写的简洁摘要,避免直接粘贴未经整理的 AI 输出。

📝 变更描述 / Description

(简述:做了什么?为什么这样改能生效?请基于你对代码逻辑的理解来写,避免粘贴未经整理的内容)
修复 MultiSelect 下拉浮层在浅色主题下被强制显示为暗色的问题。

🚀 变更类型 / Type of change

  • 🐛 Bug 修复 (Bug fix) - 请关联对应 Issue,避免将设计取舍、理解偏差或预期不一致直接归类为 bug
  • ✨ 新功能 (New feature) - 重大特性建议先通过 Issue 沟通
  • ⚡ 性能优化 / 重构 (Refactor)
  • 📝 文档更新 (Documentation)

🔗 关联任务 / Related Issue

  • Closes # (如有)

✅ 提交前检查项 / Checklist

  • 人工确认: 我已亲自整理并撰写此描述,没有直接粘贴未经处理的 AI 输出。
  • 非重复提交: 我已搜索现有的 IssuesPRs,确认不是重复提交。
  • Bug fix 说明: 若此 PR 标记为 Bug fix,我已提交或关联对应 Issue,且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。
  • 变更理解: 我已理解这些更改的工作原理及可能影响。
  • 范围聚焦: 本 PR 未包含任何与当前任务无关的代码改动。
  • 本地验证: 已在本地运行并通过测试或手动验证,维护者可以据此复核结果。
  • 安全合规: 代码中无敏感凭据,且符合项目代码规范。

📸 运行证明 / Proof of Work

(请在此粘贴截图、关键日志或测试报告,以证明变更生效)
修复前:
image

修复后:
image

Summary by CodeRabbit

  • Style
    • Enhanced combobox component styling to improve visual consistency and rendering across different display modes.

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: da86da08-6410-4e31-98b8-937c3c26a4d4

📥 Commits

Reviewing files that changed from the base of the PR and between 3280584 and c8d3768.

📒 Files selected for processing (1)
  • web/default/src/components/ui/combobox.tsx

Walkthrough

The ComboboxContent component's ComboboxPrimitive.Popup className is updated: the dark prefix is removed from the group/combobox-content styling token, replacing the conditional dark mode class with an unconditional version.

Changes

Combobox popup styling update

Layer / File(s) Summary
Remove dark prefix from combobox popup class
web/default/src/components/ui/combobox.tsx
The CSS class token in ComboboxPrimitive.Popup is updated from dark group/combobox-content to group/combobox-content on line 183.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single class did dance away,
Dark prefix vanished in a day,
The combobox now stands so bright,
With styling plain, no dark-prefixed might!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: removing dark theme prefixing from the combobox popover styling to allow theme inheritance, aligning with the PR's objective to fix theme respecting.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@t0ng7u
t0ng7u merged commit 1915344 into QuantumNous:main Jun 6, 2026
2 checks passed
OuYang-HX pushed a commit to OuYang-HX/new-api that referenced this pull request Jun 13, 2026
Merge pull request QuantumNous#5328 from yyhhyyyyyy/fix/multiselect-popover-theme
zhaodechao2008 pushed a commit to zhaodechao2008/new-api that referenced this pull request Jul 27, 2026
Merge pull request QuantumNous#5328 from yyhhyyyyyy/fix/multiselect-popover-theme
330079598 pushed a commit to 330079598/new-api that referenced this pull request Aug 19, 2026
Merge pull request QuantumNous#5328 from yyhhyyyyyy/fix/multiselect-popover-theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants