fix: use actual user id for channel tests - #5109
Merged
Merged
Conversation
Contributor
|
Caution Review failedPull request was closed or merged during review WalkthroughChannel test endpoints now resolve a test user ID from the request context or database, replacing hardcoded user references throughout test execution, logging, and context initialization. ChangesUser-aware channel testing
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ari4ka
approved these changes
May 26, 2026
52assert
added a commit
to 52assert/new-api
that referenced
this pull request
May 28, 2026
…codes * origin/main: (34 commits) fix: optimize batch update process fix: keep token log filters exact fix: keep usage log filters exact unless wildcard is explicit (QuantumNous#5097) fix(web): improve channel and usage log UI feat(theme): add simple-large preset, xl scale and clean up channel badge dots 🐛 fix(system-settings): resolve save detection and number input NaN issues 🎨 fix(logs): tune usage table typography fix: use actual user id for channel tests (QuantumNous#5109) fix: consolidate Waffo payment settings save flow (QuantumNous#5110) 🎨 fix(charts): improve dark mode chart readability 🎨 fix(logs): remove hardcoded font-mono to support global theme font inheritance 🎨 fix(logs): restore timing background badges and optimize model/token spacing feat(subscription): support balance purchases 🎨 fix(theme): default theme font preset falls back to Sans instead of Serif 🎨 refactor(badge): restore status-badge sizes and classic color scheme fix: prevent duplicate channel action toasts (QuantumNous#5015) 🎨 feat(web/default): add Anthropic theme preset and configurable serif typography ♻️ refactor(channels): rebuild channel editor UX with modular sections and Base UI multi-select ♻️ refactor(channels): rebuild channel create/edit drawer with modular sections and improved form UX fix: handle paginated API key search response (QuantumNous#5014) ... # Conflicts: # controller/misc.go # web/default/src/features/auth/sign-in/components/user-auth-form.tsx # web/default/src/features/auth/sign-in/index.tsx # web/default/src/features/auth/sign-up/components/sign-up-form.tsx # web/default/src/hooks/use-sidebar-data.ts # web/default/src/routes/__root.tsx
xyfacai
pushed a commit
to xyfacai/new-api
that referenced
this pull request
May 30, 2026
isboyjc
pushed a commit
to isboyjc/amux-api
that referenced
this pull request
May 31, 2026
(cherry picked from commit 30025ae)
SamuelSxy
pushed a commit
to SamuelSxy/new-api-rh
that referenced
this pull request
Jun 7, 2026
szxufan
pushed a commit
to szxufan/new-api
that referenced
this pull request
Jun 9, 2026
fx247562340
pushed a commit
to fx247562340/vancine-platform
that referenced
this pull request
Jun 11, 2026
ysicing
pushed a commit
to ysicing/new-api
that referenced
this pull request
Aug 7, 2026
330079598
pushed a commit
to 330079598/new-api
that referenced
this pull request
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
📝 变更描述 / Description
(简述:做了什么?为什么这样改能生效?请基于你对代码逻辑的理解来写,避免粘贴未经整理的内容)
渠道测试硬编码userid=1修正为读取实际数据
🚀 变更类型 / Type of change
🔗 关联任务 / Related Issue
✅ 提交前检查项 / Checklist
Bug fix,我已提交或关联对应 Issue,且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。📸 运行证明 / Proof of Work
(请在此粘贴截图、关键日志或测试报告,以证明变更生效)
Summary by CodeRabbit
Bug Fixes
Tests