fix: clarify affinity disabled channel retry message - #4453
Conversation
WalkthroughThis PR adds a new i18n message key Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
i18n/locales/en.yaml (1)
260-260: Optional: minor phrasing polish."retry was stopped by rule" reads awkwardly in English. Consider a more idiomatic phrasing such as "retries have been halted per policy" to better match the Chinese source ("已按规则停止重试").
✏️ Proposed wording
-distributor.affinity_channel_disabled: "The channel selected by channel affinity has been disabled, and retry was stopped by rule. Please contact the administrator" +distributor.affinity_channel_disabled: "The channel selected by channel affinity has been disabled; retries have been halted per policy. Please contact the administrator."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@i18n/locales/en.yaml` at line 260, Update the translation value for the key distributor.affinity_channel_disabled to use more idiomatic English; replace "retry was stopped by rule" with phrasing like "retries have been halted per policy" so the full message reads: "The channel selected by channel affinity has been disabled, and retries have been halted per policy. Please contact the administrator" — locate the key distributor.affinity_channel_disabled in en.yaml and update its string accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@i18n/locales/en.yaml`:
- Line 260: Update the translation value for the key
distributor.affinity_channel_disabled to use more idiomatic English; replace
"retry was stopped by rule" with phrasing like "retries have been halted per
policy" so the full message reads: "The channel selected by channel affinity has
been disabled, and retries have been halted per policy. Please contact the
administrator" — locate the key distributor.affinity_channel_disabled in en.yaml
and update its string accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4e18f30b-c343-4195-bcc5-7dbf3110d0f4
📒 Files selected for processing (5)
i18n/keys.goi18n/locales/en.yamli18n/locales/zh-CN.yamli18n/locales/zh-TW.yamlmiddleware/distributor.go
Important
📝 变更描述 / Description
(简述:做了什么?为什么这样改能生效?请基于你对代码逻辑的理解来写,避免粘贴未经整理的内容)
修改渠道亲和性命中的渠道被禁用的提示文案
“渠道亲和性命中的渠道已被禁用,已按规则停止重试,请联系管理员处理“
🚀 变更类型 / Type of change
🔗 关联任务 / Related Issue
✅ 提交前检查项 / Checklist
Bug fix,我已提交或关联对应 Issue,且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。📸 运行证明 / Proof of Work
(请在此粘贴截图、关键日志或测试报告,以证明变更生效)
Summary by CodeRabbit