Skip to content

fix: correct gpt-5.5 completion ratio - #4414

Merged
Calcium-Ion merged 1 commit into
QuantumNous:mainfrom
lov-team:codex/fix-gpt-55-completion-ratio
Apr 24, 2026
Merged

fix: correct gpt-5.5 completion ratio#4414
Calcium-Ion merged 1 commit into
QuantumNous:mainfrom
lov-team:codex/fix-gpt-55-completion-ratio

Conversation

@jingx8885

@jingx8885 jingx8885 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Summary\n- Add a gpt-5.5-specific completion ratio rule so it uses the official 6x output/input multiplier instead of falling through to the gpt-5 default 8x rule.\n- Add regression coverage for gpt-5.5 and dated gpt-5.5 variants.\n\n## Test\n- go test ./setting/ratio_setting

Summary by CodeRabbit

  • Bug Fixes

    • Fixed completion ratio calculation for gpt-5.5 model variants to use the correct official multiplier value, ensuring accurate resource allocation and billing.
  • Tests

    • Added test coverage for gpt-5.5 model completion ratio handling, including support for dated variant formats.

@coderabbitai

coderabbitai Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 66d130b2-7f31-453f-bdc3-7c1f6402f8ab

📥 Commits

Reviewing files that changed from the base of the PR and between 65b1654 and df6d862.

📒 Files selected for processing (2)
  • setting/ratio_setting/model_ratio.go
  • setting/ratio_setting/model_ratio_test.go

Walkthrough

This change adds explicit support for gpt-5.5 model variants in the completion ratio configuration system. The modification introduces a new prefix check that returns a completion ratio of 6 with locked status for any model names starting with gpt-5.5, along with comprehensive unit tests to verify the behavior.

Changes

Cohort / File(s) Summary
Model Ratio Configuration
setting/ratio_setting/model_ratio.go
Added explicit gpt-5.5 model name prefix check that returns completion ratio of 6 with locked status, positioned before the generic gpt-5 fallback handler.
Unit Tests
setting/ratio_setting/model_ratio_test.go
New test file with two test cases verifying that gpt-5.5 models resolve to completion ratio 6 with locked status, including tests for both the base model name and a dated variant (gpt-5.5-2026-04-24).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 A fuzzy model named gpt-5.5 hops along,
With ratio six, locked tight and strong!
Tests verify each variant's place,
From base name to timestamped grace.
Our completion logic now complete! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a specific completion ratio rule for gpt-5.5 models.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Calcium-Ion
Calcium-Ion merged commit 05b0041 into QuantumNous:main Apr 24, 2026
2 checks passed
Jinxuans referenced this pull request in TokFlux-Org/TokFlux May 9, 2026
@jingx8885
jingx8885 deleted the codex/fix-gpt-55-completion-ratio branch May 27, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants