Repository navigation
feat(frontend): add custom navigation items support with drag-and-drop reordering #4082
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| Copyright (C) 2025 QuantumNous | ||
|
|
||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU Affero General Public License as | ||
| published by the Free Software Foundation, either version 3 of the | ||
| License, or (at your option) any later version. | ||
|
|
||
| This program is distributed in the hope that it will be useful, | ||
| but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| GNU Affero General Public License for more details. | ||
|
|
||
| You should have received a copy of the GNU Affero General Public License | ||
| along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| For commercial licensing, please contact support@quantumnous.com | ||
| */ | ||
|
|
||
| const BUILT_IN_ORDER = ['home', 'console', 'pricing', 'docs', 'about']; | ||
|
|
||
| export function migrateOldFormatToItems(modules) { | ||
| const items = BUILT_IN_ORDER.map((key) => { | ||
| if (key === 'pricing') { | ||
| const val = modules[key]; | ||
| if (typeof val === 'object') { | ||
| return { | ||
| key, | ||
| enabled: val.enabled !== false, | ||
| requireAuth: val.requireAuth || false, | ||
| }; | ||
| } | ||
| return { key, enabled: val !== false, requireAuth: false }; | ||
| } | ||
| return { key, enabled: modules[key] !== false }; | ||
| }); | ||
|
|
||
| const customItems = Array.isArray(modules.customItems) | ||
| ? modules.customItems | ||
| : []; | ||
| const sorted = [...customItems].sort( | ||
| (a, b) => (a.position ?? 99) - (b.position ?? 99), | ||
| ); | ||
|
|
||
| const cursors = new Map(); | ||
| for (const ci of sorted) { | ||
| const pos = ci.position ?? 99; | ||
| const { position: _, ...rest } = ci; | ||
| const customItem = { ...rest }; | ||
|
|
||
| if (pos === 0) { | ||
| const cursor = cursors.get('start') ?? 0; | ||
| items.splice(cursor, 0, customItem); | ||
| cursors.set('start', cursor + 1); | ||
| } else if (pos === 99) { | ||
| items.push(customItem); | ||
| } else { | ||
| const anchorKey = BUILT_IN_ORDER[pos - 1]; | ||
| const anchorIdx = items.findIndex((it) => it.key === anchorKey); | ||
| if (anchorIdx >= 0) { | ||
| const cursor = cursors.get(anchorKey) ?? anchorIdx + 1; | ||
| items.splice(cursor, 0, customItem); | ||
| cursors.set(anchorKey, cursor + 1); | ||
| } else { | ||
| items.push(customItem); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return items; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Harden migration against malformed persisted config.
At Line 26 and Line 48, null/non-object values can throw (
pricing: null,customItems: [null]) and break header rendering. Please guard object assumptions before property access/destructuring.🔧 Proposed defensive fix
export function migrateOldFormatToItems(modules) { + const safeModules = + modules && typeof modules === 'object' && !Array.isArray(modules) + ? modules + : {}; + const items = BUILT_IN_ORDER.map((key) => { if (key === 'pricing') { - const val = modules[key]; - if (typeof val === 'object') { + const val = safeModules[key]; + if (val && typeof val === 'object' && !Array.isArray(val)) { return { key, enabled: val.enabled !== false, - requireAuth: val.requireAuth || false, + requireAuth: val.requireAuth === true, }; } return { key, enabled: val !== false, requireAuth: false }; } - return { key, enabled: modules[key] !== false }; + return { key, enabled: safeModules[key] !== false }; }); - const customItems = Array.isArray(modules.customItems) - ? modules.customItems + const customItems = Array.isArray(safeModules.customItems) + ? safeModules.customItems.filter( + (ci) => ci && typeof ci === 'object' && !Array.isArray(ci), + ) : [];🤖 Prompt for AI Agents