Skip to content

refactor: expose skip-retry option and show it in rules list - #3440

Merged
Calcium-Ion merged 1 commit into
QuantumNous:mainfrom
seefs001:refactor/expose-skip-retry-option
Mar 25, 2026
Merged

refactor: expose skip-retry option and show it in rules list#3440
Calcium-Ion merged 1 commit into
QuantumNous:mainfrom
seefs001:refactor/expose-skip-retry-option

Conversation

@seefs001

@seefs001 seefs001 commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added a visual status column for skip retry on failure in the rules table with color-coded indicators
    • Relocated skip retry on failure setting from advanced options to the main settings area for improved accessibility

@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a5f6b86e-b315-4a47-9468-e6711f918259

📥 Commits

Reviewing files that changed from the base of the PR and between ff66288 and 6154b8e.

📒 Files selected for processing (1)
  • web/src/pages/Setting/Operation/SettingsChannelAffinity.jsx

Walkthrough

A UI layout reorganization where the skip_retry_on_failure control is relocated from an advanced settings collapse panel to the main modal section, with a corresponding table column added to display this setting's status in the visual rules list.

Changes

Cohort / File(s) Summary
UI Component Reorganization
web/src/pages/Setting/Operation/SettingsChannelAffinity.jsx
Moved skip_retry_on_failure form control outside the "高级设置" collapse panel into the main modal area; added table column displaying the field status as a localized Tag (是/否) for visual rules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A checkbox takes a little hop,
From deep inside the panel drop,
Now front and center, bold and bright,
With Tag companions shining right!
The rules can see it plain as day—
or won't hide away!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Calcium-Ion
Calcium-Ion merged commit 22b6b16 into QuantumNous:main Mar 25, 2026
1 check was pending
VeryGoodUser1 pushed a commit to xmz-ai/new-api that referenced this pull request Apr 3, 2026
…p-retry-option

refactor: expose skip-retry option and show it in rules list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants