feat(waffo): Waffo payment gateway integration - #3293
Merged
seefs001 merged 7 commits intoMar 18, 2026
Conversation
- Add Waffo payment SDK integration (waffo-go v1.3.1) - Backend: webhook handler, pay endpoint, order lock race-condition fix - Settings: full Waffo config (API keys, sandbox/prod, currency, pay methods) - Frontend: Waffo payment buttons in topup page, admin settings panel - i18n: Waffo-related translations for en/fr/ja/ru/vi/zh-TW Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds Waffo payment gateway (SDK integration, payment creation, webhook handling, and finalization), new Waffo settings and admin UI, frontend top-up UI/i18n updates, a new TopUpStatusFailed constant, and refactors per-order locking to a reference‑counted mutex. (50 words) Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant Client as Frontend Client
participant Server as Backend Server
participant Waffo as Waffo Gateway
participant DB as Database
participant Recharge as Recharge Logic
User->>Client: Start Waffo payment (select amount/method)
Client->>Server: POST /user/waffo/pay (amount, payMethodIndex)
Server->>DB: Create TopUp record (status=pending)
Server->>Waffo: Create payment order via SDK
Waffo-->>Server: Return payment URL & order ID
Server-->>Client: Return payment URL
Client->>Waffo: User completes payment
Waffo->>Server: POST /waffo/webhook (signed)
Server->>Server: Verify signature
Server->>Server: Lock order (ref-counted mutex)
Server->>DB: SELECT ... FOR UPDATE (TopUp)
Server->>DB: Update TopUp status -> success
Server->>Recharge: Invoke RechargeWaffo (quota update)
Recharge->>DB: Update user quota
Server->>Server: Unlock order
Server-->>Waffo: Respond to webhook
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 9
🧹 Nitpick comments (1)
controller/topup_waffo.go (1)
51-53: Consider using a more descriptive fake email domain.The
examples.comdomain is not a reserved domain for testing. Consider usingexample.com(RFC 2606 reserved) or a domain clearly owned by the service.Suggested fix
func getWaffoUserEmail(user *model.User) string { - return fmt.Sprintf("%d@examples.com", user.Id) + return fmt.Sprintf("%d@example.com", user.Id) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@controller/topup_waffo.go` around lines 51 - 53, The getWaffoUserEmail function currently uses "examples.com" which is not an RFC2606 reserved test domain; update getWaffoUserEmail (which formats the email from model.User Id) to use a descriptive, reserved or service-owned domain such as "example.com" or your service's owned test domain instead, e.g., change the domain string in the fmt.Sprintf call within getWaffoUserEmail to "example.com" (or another approved domain).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@common/constants.go`:
- Around line 212-215: The UI mapping for top-up statuses is missing the new
failed status so orders saved with common.TopUpStatusFailed render a raw badge;
update the TopupHistoryModal.jsx status-to-badge mapping to handle the "failed"
status (compare against TopUpStatusFailed or the literal "failed") and return
the appropriate Badge variant/text (match the visual style used for failures
elsewhere, e.g., a danger/error badge and label "Failed") so failed orders
display a consistent styled badge instead of raw text.
In `@controller/topup_waffo.go`:
- Around line 259-267: The code reads orderData.AcquiringOrderID but never
persists it because TopUp has no GatewayOrderId field; to fix, add a
GatewayOrderId string field to the TopUp struct in model/topup.go (or choose an
existing field to repurpose), update any DB mapping/migration as needed, then
before calling topUp.Update() assign topUp.GatewayOrderId =
orderData.AcquiringOrderID so the subsequent topUp.Update() persists the
acquiring order ID and preserves refund functionality.
In `@model/topup.go`:
- Around line 393-395: The Transaction block in RechargeWaffo (in
model/topup.go) uses tx.Set("gorm:query_option", "FOR UPDATE") which breaks on
SQLite; change it to skip the FOR UPDATE clause when running under SQLite (e.g.,
wrap the Set call with a dialect check such as if !common.UsingSQLite {
tx.Set("gorm:query_option", "FOR UPDATE") }) or refactor the logic to an atomic
state-transition UPDATE (UPDATE ... WHERE trade_no = ? AND status = ?) instead
of selecting with FOR UPDATE so the behavior is compatible across SQLite, MySQL
and Postgres; locate the Transaction lambda that calls
tx.Set(...).Where(...).First(topUp) and apply the conditional or replace with
the atomic UPDATE pattern.
In `@web/src/components/topup/index.jsx`:
- Around line 317-321: The UI currently reuses the shared minTopUp for Waffo,
causing server-side rejections; add and use a dedicated waffoMinTopUp
variable/state (e.g., derived from config prop or API) and replace usages of
minTopUp within the Waffo path (specifically inside the waffoTopUp function and
the other Waffo-specific validation block around lines 483-496) to validate
against waffoMinTopUp so the client-side check matches
controller/topup_waffo.go's WaffoMinTopUp requirement.
In `@web/src/components/topup/RechargeCard.jsx`:
- Line 236: The outer JSX conditional currently uses (enableOnlineTopUp ||
enableStripeTopUp || enableWaffoTopUp) which causes the generic "暂无可用的支付方式..."
selector to render when Waffo is the only gateway; update the guard so Waffo
alone doesn't trigger this empty-state — either remove enableWaffoTopUp from
that outer condition or refine it to only include enableWaffoTopUp when
payMethods is empty (e.g. (enableOnlineTopUp || enableStripeTopUp ||
(enableWaffoTopUp && (!payMethods || payMethods.length === 0)))); apply the same
change to the other identical block that spans the 295-363 region so the generic
selector only shows when appropriate.
In `@web/src/i18n/locales/fr.json`:
- Around line 3163-3172: The fr locale is missing several new Waffo translation
keys used by RechargeCard.jsx and SettingsPaymentGatewayWaffo.jsx; add French
entries using the original Chinese source strings as keys (e.g. "Waffo 充值",
"Waffo 设置", "启用 Waffo", "更新 Waffo 设置", "新增支付方式" and any other Waffo-related keys
introduced by those components) into web/src/i18n/locales/fr.json so the UI does
not fall back to Chinese/English—use accurate French translations for each
Chinese key and keep the key names exactly as in the code.
In `@web/src/i18n/locales/zh-TW.json`:
- Line 2903: The translation string for the key
"提示：端点映射仅用于模型广场展示，不会影响模型真实调用。如需配置真实调用，请前往「渠道管理」。" uses 「頻道管理」 but the locale
uses 「管道管理」 elsewhere; update the value to replace 「頻道管理」 with 「管道管理」 so the
JSON entry becomes consistent with the existing zh-TW terminology.
In `@web/src/pages/Setting/Payment/SettingsPaymentGatewayWaffo.jsx`:
- Around line 394-408: The two secret fields currently use Form.TextArea (fields
WaffoPrivateKey and WaffoSandboxPrivateKey) so the type='password' prop is
ignored; replace them with a password-capable input or add an explicit
reveal/hide control: swap Form.TextArea for a password input component (e.g.,
Input.Password or a controlled component that toggles masking) bound to the same
field names WaffoPrivateKey and WaffoSandboxPrivateKey, preserve autosize/visual
needs by providing a monospace font or a toggle that switches between masked
Input.Password and a read-only TextArea for viewing, and ensure the Form
bindings/validation remain unchanged.
- Around line 20-36: The file has a top-level statement breaking ESM: move the
destructuring const { Text } = Typography so that all import statements remain
first (keep imports of React, semi-ui components, API, showError/showSuccess,
and useTranslation before any other code and then add const { Text } =
Typography immediately after those imports); also replace the two occurrences of
Form.TextArea used for RSA private keys (referenced in the JSX where
Form.TextArea is used for secrets) with a Form.Input configured with
type='password' for single-line secrets or implement a secure multi-line
alternative (e.g., a masked custom component or toggleable visibility) so
private keys are not using an unmasked TextArea.
---
Nitpick comments:
In `@controller/topup_waffo.go`:
- Around line 51-53: The getWaffoUserEmail function currently uses
"examples.com" which is not an RFC2606 reserved test domain; update
getWaffoUserEmail (which formats the email from model.User Id) to use a
descriptive, reserved or service-owned domain such as "example.com" or your
service's owned test domain instead, e.g., change the domain string in the
fmt.Sprintf call within getWaffoUserEmail to "example.com" (or another approved
domain).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9b3b8ab5-8914-421d-bb8d-ea33e29ccf1e
⛔ Files ignored due to path filters (4)
go.sumis excluded by!**/*.sumweb/public/pay-apple.pngis excluded by!**/*.pngweb/public/pay-card.pngis excluded by!**/*.pngweb/public/pay-google.pngis excluded by!**/*.png
📒 Files selected for processing (20)
common/constants.goconstant/waffo_pay_method.gocontroller/topup.gocontroller/topup_waffo.gogo.modmodel/option.gomodel/topup.gorouter/api-router.gosetting/payment_waffo.goweb/src/components/settings/PaymentSetting.jsxweb/src/components/topup/RechargeCard.jsxweb/src/components/topup/index.jsxweb/src/components/topup/modals/TopupHistoryModal.jsxweb/src/i18n/locales/en.jsonweb/src/i18n/locales/fr.jsonweb/src/i18n/locales/ja.jsonweb/src/i18n/locales/ru.jsonweb/src/i18n/locales/vi.jsonweb/src/i18n/locales/zh-TW.jsonweb/src/pages/Setting/Payment/SettingsPaymentGatewayWaffo.jsx
The backend defines TopUpStatusFailed = "failed" but the frontend STATUS_CONFIG was missing this status, causing raw text display instead of a styled danger badge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The code read orderData.AcquiringOrderID but never assigned it to any TopUp field before calling Update(), making the block a no-op. Removed since GatewayOrderId storage is not needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The waffoTopUp function was validating against the shared minTopUp which could be set by epay/stripe when multiple gateways are enabled, causing mismatch with backend's WaffoMinTopUp check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@controller/topup_waffo.go`:
- Around line 51-53: The getWaffoUserEmail function currently formats addresses
with the non-reserved domain "examples.com"; change it to use the reserved
testing domain "example.com" by updating the format string in getWaffoUserEmail
(which references user.Id on model.User) so emails are generated as
"%d@example.com" instead of "%d@examples.com".
- Around line 341-353: The code marks a pending top-up as failed but discards
any error from topUp.Update(), hiding DB failures; change the block that calls
model.GetTopUpByTradeNo and updates topUp.Status (the branch using
TopUpStatusPending and setting to TopUpStatusFailed) to capture the returned
error from topUp.Update(), and log it (e.g., via log.Printf or the package
logger) including context like result.MerchantOrderID and the operation
("topUp.Update") so DB update failures are visible; ensure you do this for the
Update() call in this Waffo handler similarly to how other handlers (topup.go,
topup_stripe.go) log Update() errors.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e2fe7094-0fe4-4285-b0ee-ebe03fec872b
📒 Files selected for processing (1)
controller/topup_waffo.go
Comment on lines
+51
to
+53
| func getWaffoUserEmail(user *model.User) string { | ||
| return fmt.Sprintf("%d@examples.com", user.Id) | ||
| } |
Contributor
There was a problem hiding this comment.
Typo: Use example.com instead of examples.com.
RFC 2606 reserves example.com for documentation and testing purposes, while examples.com is a potentially purchasable domain. Using the non-reserved domain could inadvertently route emails to a third party.
🔧 Proposed fix
func getWaffoUserEmail(user *model.User) string {
- return fmt.Sprintf("%d@examples.com", user.Id)
+ return fmt.Sprintf("%d@example.com", user.Id)
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| func getWaffoUserEmail(user *model.User) string { | |
| return fmt.Sprintf("%d@examples.com", user.Id) | |
| } | |
| func getWaffoUserEmail(user *model.User) string { | |
| return fmt.Sprintf("%d@example.com", user.Id) | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@controller/topup_waffo.go` around lines 51 - 53, The getWaffoUserEmail
function currently formats addresses with the non-reserved domain
"examples.com"; change it to use the reserved testing domain "example.com" by
updating the format string in getWaffoUserEmail (which references user.Id on
model.User) so emails are generated as "%d@example.com" instead of
"%d@examples.com".
Comment on lines
+341
to
+353
| if result.OrderStatus != "PAY_SUCCESS" { | ||
| log.Printf("Waffo 订单状态非成功: %s, 订单: %s", result.OrderStatus, result.MerchantOrderID) | ||
| // 终态失败订单标记为 failed，避免永远停在 pending | ||
| if result.MerchantOrderID != "" { | ||
| if topUp := model.GetTopUpByTradeNo(result.MerchantOrderID); topUp != nil && | ||
| topUp.Status == common.TopUpStatusPending { | ||
| topUp.Status = common.TopUpStatusFailed | ||
| _ = topUp.Update() | ||
| } | ||
| } | ||
| sendWaffoWebhookResponse(c, wh, true, "") | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Waffo payment webhook notification order status values documentation
💡 Result:
Waffo (waffo.com), a global payment and monetization platform, supports webhook notifications for real-time updates on payments, refunds, and subscriptions. Official documentation is referenced in their Go SDK (github.com/waffo-com/waffo-go), which handles webhook events including PaymentNotification with OrderStatus and SubscriptionStatusNotification. From the Waffo Go SDK documentation: - Webhook types: PAYMENT_NOTIFICATION (payment result, OrderStatus), REFUND_NOTIFICATION, SUBSCRIPTION_STATUS_NOTIFICATION (subscription status changes like IN_PROGRESS, AUTHORIZATION_REQUIRED, SUCCESS, CLOSED), SUBSCRIPTION_PAYMENT_NOTIFICATION, SUBSCRIPTION_PERIOD_CHANGED_NOTIFICATION. Waffo also has partial docs at docs.waffo.com (e.g., Google Pay integration mentions orderStatus: "Success"). A closely related payment gateway, WaafiPay (docs.waafipay.com/webhooks), explicitly documents payment webhook status values in payment.status: - APPROVED: Transaction succeeded (fulfill order) - FAILED: Technical error (cancel order, log error) - DECLINED: Declined (retry or alternative payment) - CANCELED: Canceled by user - EXPIRED: Session expired - TIMEOUT: Timeout Events: webhook.test, authorization, refund. No complete official Waffo webhook docs found in public searches, but SDK and related sources indicate similar payment/order statuses (e.g., Success, OrderStatus field). Contact Waffo support or check developer portal after signup for full docs. Sites: waffo.com, dev.waffo.com, docs.waffo.com.
Citations:
- 1: https://docs.waafipay.com/webhooks
- 2: https://dev.waffo.com/
- 3: https://docs.waffo.com/docs/google-pay/?open_in_browser=true
- 4: https://libraries.io/go/github.com%2Fwaffo-com%2Fwaffo-go
- 5: https://waffo.com/
🏁 Script executed:
# Find TopUp model definition and status constants
fd -e go -x rg -l "TopUpStatus|type TopUp" {} \; | head -20Repository: QuantumNous/new-api
Length of output: 339
🏁 Script executed:
# Check for status constants and enums
rg -A 5 "TopUpStatusPending|TopUpStatusFailed" --type goRepository: QuantumNous/new-api
Length of output: 6153
🏁 Script executed:
# Find Stripe webhook handler mentioned in the comment context
rg -B 5 -A 15 "handleStripePaymentEvent|LockOrder.*UnlockOrder" --type goRepository: QuantumNous/new-api
Length of output: 45
🏁 Script executed:
# Search for Waffo documentation or configuration
rg -i "waffo" --type go -B 2 -A 5 | head -100Repository: QuantumNous/new-api
Length of output: 6225
🏁 Script executed:
# Find Stripe webhook handler
rg -B 5 -A 30 "func StripeWebhook|handleStripePaymentEvent" --type go | head -80Repository: QuantumNous/new-api
Length of output: 1924
🏁 Script executed:
# Check the full Waffo webhook handler
rg -B 5 -A 50 "func.*WaffoWebhook|handleWaffoPayment" --type go | head -150Repository: QuantumNous/new-api
Length of output: 5536
🏁 Script executed:
# Search for any Waffo order status handling or documentation
rg -i "orderStatus|payment.*status|waffo.*status" --type go | grep -i waffoRepository: QuantumNous/new-api
Length of output: 458
🏁 Script executed:
# Check all Update() error handling patterns in payment handlers
rg "topUp.Update|order.Update" --type go -B 2 -A 2Repository: QuantumNous/new-api
Length of output: 1801
Log Update() errors to catch database failures.
Multiple Update() calls silently ignore errors (e.g., line 348: _ = topUp.Update()). This prevents visibility into database issues when status transitions fail. Other payment handlers in the codebase (e.g., topup.go, topup_stripe.go) properly log these errors.
🔧 Suggested improvement
if topUp := model.GetTopUpByTradeNo(result.MerchantOrderID); topUp != nil &&
topUp.Status == common.TopUpStatusPending {
topUp.Status = common.TopUpStatusFailed
- _ = topUp.Update()
+ if err := topUp.Update(); err != nil {
+ log.Printf("Waffo 更新订单状态失败: %v, 订单: %s", err, result.MerchantOrderID)
+ }
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if result.OrderStatus != "PAY_SUCCESS" { | |
| log.Printf("Waffo 订单状态非成功: %s, 订单: %s", result.OrderStatus, result.MerchantOrderID) | |
| // 终态失败订单标记为 failed，避免永远停在 pending | |
| if result.MerchantOrderID != "" { | |
| if topUp := model.GetTopUpByTradeNo(result.MerchantOrderID); topUp != nil && | |
| topUp.Status == common.TopUpStatusPending { | |
| topUp.Status = common.TopUpStatusFailed | |
| _ = topUp.Update() | |
| } | |
| } | |
| sendWaffoWebhookResponse(c, wh, true, "") | |
| return | |
| } | |
| if result.OrderStatus != "PAY_SUCCESS" { | |
| log.Printf("Waffo 订单状态非成功: %s, 订单: %s", result.OrderStatus, result.MerchantOrderID) | |
| // 终态失败订单标记为 failed，避免永远停在 pending | |
| if result.MerchantOrderID != "" { | |
| if topUp := model.GetTopUpByTradeNo(result.MerchantOrderID); topUp != nil && | |
| topUp.Status == common.TopUpStatusPending { | |
| topUp.Status = common.TopUpStatusFailed | |
| if err := topUp.Update(); err != nil { | |
| log.Printf("Waffo 更新订单状态失败: %v, 订单: %s", err, result.MerchantOrderID) | |
| } | |
| } | |
| } | |
| sendWaffoWebhookResponse(c, wh, true, "") | |
| return | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@controller/topup_waffo.go` around lines 341 - 353, The code marks a pending
top-up as failed but discards any error from topUp.Update(), hiding DB failures;
change the block that calls model.GetTopUpByTradeNo and updates topUp.Status
(the branch using TopUpStatusPending and setting to TopUpStatusFailed) to
capture the returned error from topUp.Update(), and log it (e.g., via log.Printf
or the package logger) including context like result.MerchantOrderID and the
operation ("topUp.Update") so DB update failures are visible; ensure you do this
for the Update() call in this Waffo handler similarly to how other handlers
(topup.go, topup_stripe.go) log Update() errors.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
web/src/components/topup/index.jsx (2)
573-580: Intentional empty dependency array for redirect handling.The
[]dependency array is correct here for one-time URL parameter processing after payment redirects. If you encounter ESLintexhaustive-depswarnings, consider adding a disable comment with explanation:// eslint-disable-next-line react-hooks/exhaustive-deps -- intentional: process redirect params once on mount🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/src/components/topup/index.jsx` around lines 573 - 580, The useEffect that checks searchParams and sets setOpenHistory is intentionally meant to run once on mount but currently triggers an eslint exhaustive-deps warning; update the useEffect by adding an inline eslint disable comment to suppress exhaustive-deps with an explanation (e.g., above the useEffect add "// eslint-disable-next-line react-hooks/exhaustive-deps -- intentional: process redirect params once on mount") so the one-time redirect handling in useEffect (uses searchParams, setOpenHistory, setSearchParams) is preserved without linter noise.
637-639: Consider adding minimal logging for silent failures.Empty catch blocks make debugging production issues harder. Consider logging at a lower level for observability without impacting UX:
} catch (err) { console.debug('Amount fetch failed:', err); }Also applies to: 663-665
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/src/components/topup/index.jsx` around lines 637 - 639, The catch blocks silently swallow errors without any logging, making it difficult to trace failures in production. Update the catch blocks at the specified locations (including the one handling the amount fetch failure inside the function near lines 637 and 663) to log the caught errors using console.debug or equivalent logging at a lower severity so the errors are recorded for observability while not disrupting user experience.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/src/components/topup/index.jsx`:
- Around line 339-341: The call showError(res) can receive undefined (e.g.,
network failure) and ends up displaying "undefined"; update the call site (where
showError(res) is invoked) to provide a safe fallback message—either pass
showError(res || "An error occurred while processing your request") or modify
showError to treat a falsy argument as the same fallback; ensure the fallback
text matches the message used on line 337 for consistency and reference the
showError function and the call site that currently does showError(res).
---
Nitpick comments:
In `@web/src/components/topup/index.jsx`:
- Around line 573-580: The useEffect that checks searchParams and sets
setOpenHistory is intentionally meant to run once on mount but currently
triggers an eslint exhaustive-deps warning; update the useEffect by adding an
inline eslint disable comment to suppress exhaustive-deps with an explanation
(e.g., above the useEffect add "// eslint-disable-next-line
react-hooks/exhaustive-deps -- intentional: process redirect params once on
mount") so the one-time redirect handling in useEffect (uses searchParams,
setOpenHistory, setSearchParams) is preserved without linter noise.
- Around line 637-639: The catch blocks silently swallow errors without any
logging, making it difficult to trace failures in production. Update the catch
blocks at the specified locations (including the one handling the amount fetch
failure inside the function near lines 637 and 663) to log the caught errors
using console.debug or equivalent logging at a lower severity so the errors are
recorded for observability while not disrupting user experience.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a8643558-f70e-439a-b0f1-35b37ce71b9a
📒 Files selected for processing (1)
web/src/components/topup/index.jsx
Comment on lines
+339
to
+341
| } else { | ||
| showError(res); | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: showError(res) displays undefined when response is undefined.
When res is undefined (e.g., network failure), calling showError(res) will show a blank or undefined message. Use a fallback message consistent with line 337.
🐛 Proposed fix
} else {
- showError(res);
+ showError(t('支付请求失败'));
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| } else { | |
| showError(res); | |
| } | |
| } else { | |
| showError(t('支付请求失败')); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/src/components/topup/index.jsx` around lines 339 - 341, The call
showError(res) can receive undefined (e.g., network failure) and ends up
displaying "undefined"; update the call site (where showError(res) is invoked)
to provide a safe fallback message—either pass showError(res || "An error
occurred while processing your request") or modify showError to treat a falsy
argument as the same fallback; ensure the fallback text matches the message used
on line 337 for consistency and reference the showError function and the call
site that currently does showError(res).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ESM requires all import statements before other code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…te buttons When only Waffo was enabled, the generic payment method list showed a "Waffo (Global Payment)" button calling preTopUp (epay flow) instead of waffoTopUp, while the dedicated "Waffo 充值" section had the correct buttons. Fix: filter waffo entries from generic list and hide the "选择支付方式" column when no non-waffo methods exist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
seefs001
approved these changes
Mar 18, 2026
This was referenced Mar 23, 2026
This was referenced Apr 4, 2026
Merged
Closed
This was referenced May 12, 2026
This was referenced May 27, 2026
Closed
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
controller/topup_waffo.go,setting/payment_waffo.go,constant/waffo_pay_method.go(new files)controller/topup.go(Waffo pay method injection, refactored LockOrder/UnlockOrder with ref-counting)model/option.go(Waffo settings init/update),model/topup.go(RechargeWaffo function)router/api-router.go(webhook + pay routes)SettingsPaymentGatewayWaffo.jsx(new admin config panel)RechargeCard.jsx,topup/index.jsx(Waffo payment UI integration)TopupHistoryModal.jsx(Waffo payment method display)Test plan
Summary by CodeRabbit
New Features
Bug Fixes / Refactor
Chores