Skip to content

fix: jimeng i2v support multi image by metadata - #2688

Merged
seefs001 merged 1 commit into
QuantumNous:mainfrom
feitianbubu:pr/c579c7755c6b03e207853d06cc695ca7903388c9
Jan 21, 2026
Merged

fix: jimeng i2v support multi image by metadata#2688
seefs001 merged 1 commit into
QuantumNous:mainfrom
feitianbubu:pr/c579c7755c6b03e207853d06cc695ca7903388c9

Conversation

@feitianbubu

@feitianbubu feitianbubu commented Jan 19, 2026

Copy link
Copy Markdown
Member

即梦视频matadata透传图片参数支持识别图生视频和首尾生视频

Summary by CodeRabbit

  • Refactor

    • Improved image processing logic to better manage single and multi-image handling across different scenarios.
    • Streamlined image input detection and routing.
  • Chores

    • Updated dependencies to support enhanced functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Modified jimeng adaptor's image-handling logic to consolidate image length calculations across three sources (req.Images, r.BinaryDataBase64, r.ImageUrls) into a single imageLen variable, simplifying conditional branching for single vs. multi-image request routing.

Changes

Cohort / File(s) Summary
Image length consolidation
relay/channel/task/jimeng/adaptor.go
Introduced imageLen computed as max of three image source lengths; replaced individual len(req.Images) checks with imageLen in branching logic for single vs. multi-image paths; added lo dependency

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • creamlike1024
  • seefs001

Poem

🐰 Three sources merge into one,
imageLen dances in the sun,
Branches simplified with grace,
A cleaner jimeng adaptor space! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main change: adding multi-image support to jimeng i2v via metadata parameter handling. It accurately reflects the primary objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seefs001
seefs001 merged commit 642aa09 into QuantumNous:main Jan 21, 2026
1 check passed
ennnnny pushed a commit to ennnnny/new-api that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants