Skip to content

fix(model): increase TaskID varchar length to 250 for Vertex AI Veo 3.1 - #2523

Closed
BetterAndBetterII wants to merge 4663 commits into
QuantumNous:mainfrom
BetterAndBetterII:fix/vertex-veo3
Closed

fix(model): increase TaskID varchar length to 250 for Vertex AI Veo 3.1#2523
BetterAndBetterII wants to merge 4663 commits into
QuantumNous:mainfrom
BetterAndBetterII:fix/vertex-veo3

Conversation

@BetterAndBetterII

@BetterAndBetterII BetterAndBetterII commented Dec 25, 2025

Copy link
Copy Markdown

Vertex AI Veo 3.1 returns task_id values that can exceed 191 characters. Increase the column length to 250 to accommodate these longer IDs.

Fixes #2417

Summary by CodeRabbit

  • Chores
    • Updated database infrastructure to support larger task identifiers.

✏️ Tip: You can customize this high-level summary in your review settings.

feitianbubu and others added 30 commits October 10, 2025 15:25
feat: enhance HTTP client wit redirect handling and SSRF protection
feat(web): add settings & pages of privacy policy & user agreement
…nel-auto-disabled

feat: add qwen channel auto disabled
…-video-sdk

feat: support openAI sdk retrieve videos
- replace infinite sleep loop with time.Ticker to avoid goroutine leaks
- add immediate initial test execution before ticker starts
- implement frequency change detection and ticker recreation
- ensure proper ticker cleanup when loop exits or feature disabled
…ncy-updates

fix(channel): handle dynamic frequency updates
Add comprehensive i18next configuration for internationalization support with Chinese, English, and French locales. Configure extraction settings and ignore patterns for React components. Expand translation glossary with security and billing terminology including Two-Factor Authentication, 2FA, and pricing multiplier terms.
Relocated i18next-cli from dependencies to devDependencies as it's only needed for development tasks like translation management, not for runtime functionality.
Converted i18next.config.ts to i18next.config.js and added AGPL license header. The change simplifies the build process by removing TypeScript compilation for this configuration file while maintaining the same functionality.
Reordered the ignoredAttributes array in i18next.config.js alphabetically and added several new attributes to prevent unnecessary translation extraction. This improves the localization process by excluding more non-translatable properties like accept, align, autoComplete, clipRule, crossOrigin, and others.
Enable i18next pluralization by setting disablePlurals to false and update multiple translation keys to use _one/_other suffixes for proper singular/plural handling. This improves localization accuracy for count-dependent strings like "X keys", "X models", and "X times".
- Add pluralization rules for French locale using _one, _many, _other suffixes
- Complete missing French translations for web search, file search, and key count strings
- Add translations for import/export configuration functionality
- Fill in missing translations for UI elements like ID, IP, expand, and various status messages
- Improve French localization coverage for better user experience
feat: sora 增加参数校验与计费
seefs001 and others added 23 commits November 15, 2025 13:26
support reasoning field for playground
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.1.0...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…-error

fix: boundary parser error (error parsing multipart NextPart: bufio: buffer full)
…ttings

feat: support configuring the linuxdo endpoint via environment variables
…ng-plan

feat: support doubao coding plan
…nd_yarn/electron/js-yaml-4.1.1

chore(deps-dev): bump js-yaml from 4.1.0 to 4.1.1 in /electron
Vertex AI Veo 3.1 returns task_id values that can exceed 191 characters.
Increase the column length to 250 to accommodate these longer IDs.

Fixes QuantumNous#1905

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Dec 25, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The TaskID field in the Task struct has its GORM column type annotation increased from varchar(191) to varchar(250) to accommodate longer task ID strings generated by external APIs.

Changes

Cohort / File(s) Summary
Database Schema Update
model/task.go
Updated TaskID field GORM tag to increase varchar column size from 191 to 250 characters, enabling storage of longer task identifiers without truncation errors

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A column grew wide, from one-nine-one small,
To two-five-zero, the biggest of all!
Now task IDs long can rest without care,
No more data too long in the database there! 📝✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: increasing TaskID varchar length from 191 to 250 characters to support Vertex AI Veo 3.1 task IDs.
Linked Issues check ✅ Passed The pull request directly addresses issue #1905 by increasing the TaskID column length from 191 to 250 characters to accommodate longer task_id values returned by Vertex AI Veo 3.1.
Out of Scope Changes check ✅ Passed The change is narrowly scoped and directly addresses the issue: only the TaskID field's varchar length is modified, with no extraneous changes or unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b1a562 and a0697bc.

📒 Files selected for processing (1)
  • model/task.go
🔇 Additional comments (2)
model/task.go (2)

46-46: LGTM – The GORM tag syntax is correct.

The change from varchar(191) to varchar(250) is syntactically valid and follows GORM conventions properly.


46-46: Clarify MySQL index key length requirements based on your database version and configuration.

The concern about varchar(250) with utf8mb4 charset requiring 1,000 bytes is valid only for InnoDB tables using ROW_FORMAT=COMPACT or REDUNDANT (which have a 767-byte index key limit). Modern MySQL versions (5.7.7+) default to ROW_FORMAT=DYNAMIC, which supports up to 3,072 bytes. Verify your MySQL configuration and either:

  • Confirm your instance uses ROW_FORMAT=DYNAMIC or COMPRESSED, or
  • Reduce the column size if constrained to older row formats.

For Vertex AI Veo 3.1, the task_id is a base64-encoded Google Cloud operation name (format: projects/{id}/locations/{region}/publishers/google/models/{model}/operations/{id}), which typically encodes to ~240-290 characters. The 250-character limit appears appropriately sized for this use case.

Comment thread model/task.go
CreatedAt int64 `json:"created_at" gorm:"index"`
UpdatedAt int64 `json:"updated_at"`
TaskID string `json:"task_id" gorm:"type:varchar(191);index"` // 第三方id,不一定有/ song id\ Task id
TaskID string `json:"task_id" gorm:"type:varchar(250);index"` // 第三方id,不一定有/ song id\ Task id

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Database migration required for existing installations.

This GORM model change updates the schema definition but does not automatically alter existing database tables. Deployments with existing data will encounter MySQL Error 1406 until the column is manually resized.

Consider providing a migration script or documenting the required ALTER TABLE command for operators.

📝 Example migration command
ALTER TABLE tasks MODIFY COLUMN task_id VARCHAR(250);

Note: The exact table name should match your GORM configuration.

🤖 Prompt for AI Agents
In model/task.go around line 46, the struct tag change to
`gorm:"type:varchar(250);index"` requires a database migration for existing
installations to avoid MySQL Error 1406; add a migration step (or document it)
that runs an ALTER TABLE to modify the column size, e.g. ALTER TABLE tasks
MODIFY COLUMN task_id VARCHAR(250); and include the migration file or
instructions in the deployment docs and your migration tooling
(golang-migrate/liquibase/your choice) so deployments run the schema change
before this release.

@BetterAndBetterII

Copy link
Copy Markdown
Author

@seefs001

@seefs001

Copy link
Copy Markdown
Collaborator

@seefs001

上面那个ai也给你提示了,这个是不能改的。
需要兼容低版本mysql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Veo3.1 Fast Video Generation in Vertex failed