fix(model): increase TaskID varchar length to 250 for Vertex AI Veo 3.1 - #2523
fix(model): increase TaskID varchar length to 250 for Vertex AI Veo 3.1#2523BetterAndBetterII wants to merge 4663 commits into
Conversation
feat: enhance HTTP client wit redirect handling and SSRF protection
feat(web): add settings & pages of privacy policy & user agreement
fix: channel remark ignore issue
…h-task 支持Sora做为上游渠道
feat: pplx channel
…nel-auto-disabled feat: add qwen channel auto disabled
…-video-sdk feat: support openAI sdk retrieve videos
- replace infinite sleep loop with time.Ticker to avoid goroutine leaks - add immediate initial test execution before ticker starts - implement frequency change detection and ticker recreation - ensure proper ticker cleanup when loop exits or feature disabled
…ncy-updates fix(channel): handle dynamic frequency updates
Add comprehensive i18next configuration for internationalization support with Chinese, English, and French locales. Configure extraction settings and ignore patterns for React components. Expand translation glossary with security and billing terminology including Two-Factor Authentication, 2FA, and pricing multiplier terms.
Relocated i18next-cli from dependencies to devDependencies as it's only needed for development tasks like translation management, not for runtime functionality.
Converted i18next.config.ts to i18next.config.js and added AGPL license header. The change simplifies the build process by removing TypeScript compilation for this configuration file while maintaining the same functionality.
Reordered the ignoredAttributes array in i18next.config.js alphabetically and added several new attributes to prevent unnecessary translation extraction. This improves the localization process by excluding more non-translatable properties like accept, align, autoComplete, clipRule, crossOrigin, and others.
Enable i18next pluralization by setting disablePlurals to false and update multiple translation keys to use _one/_other suffixes for proper singular/plural handling. This improves localization accuracy for count-dependent strings like "X keys", "X models", and "X times".
- Add pluralization rules for French locale using _one, _many, _other suffixes - Complete missing French translations for web search, file search, and key count strings - Add translations for import/export configuration functionality - Fill in missing translations for UI elements like ID, IP, expand, and various status messages - Improve French localization coverage for better user experience
支持可灵使用openai sdk生成视频
feat: sora 增加参数校验与计费
support reasoning field for playground
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…NextPart: bufio: buffer full)
…-error fix: boundary parser error (error parsing multipart NextPart: bufio: buffer full)
feat: support vertex open source models
…ttings feat: support configuring the linuxdo endpoint via environment variables
…ng-plan feat: support doubao coding plan
update model categories' match rules
…nd_yarn/electron/js-yaml-4.1.1 chore(deps-dev): bump js-yaml from 4.1.0 to 4.1.1 in /electron
feat: gemini-3-pro
feat: channel by tag omit key
Vertex AI Veo 3.1 returns task_id values that can exceed 191 characters. Increase the column length to 250 to accommodate these longer IDs. Fixes QuantumNous#1905 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughThe TaskID field in the Task struct has its GORM column type annotation increased from varchar(191) to varchar(250) to accommodate longer task ID strings generated by external APIs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
model/task.go
🔇 Additional comments (2)
model/task.go (2)
46-46: LGTM – The GORM tag syntax is correct.The change from
varchar(191)tovarchar(250)is syntactically valid and follows GORM conventions properly.
46-46: Clarify MySQL index key length requirements based on your database version and configuration.The concern about
varchar(250)withutf8mb4charset requiring 1,000 bytes is valid only for InnoDB tables usingROW_FORMAT=COMPACTorREDUNDANT(which have a 767-byte index key limit). Modern MySQL versions (5.7.7+) default toROW_FORMAT=DYNAMIC, which supports up to 3,072 bytes. Verify your MySQL configuration and either:
- Confirm your instance uses
ROW_FORMAT=DYNAMICorCOMPRESSED, or- Reduce the column size if constrained to older row formats.
For Vertex AI Veo 3.1, the task_id is a base64-encoded Google Cloud operation name (format:
projects/{id}/locations/{region}/publishers/google/models/{model}/operations/{id}), which typically encodes to ~240-290 characters. The 250-character limit appears appropriately sized for this use case.
| CreatedAt int64 `json:"created_at" gorm:"index"` | ||
| UpdatedAt int64 `json:"updated_at"` | ||
| TaskID string `json:"task_id" gorm:"type:varchar(191);index"` // 第三方id,不一定有/ song id\ Task id | ||
| TaskID string `json:"task_id" gorm:"type:varchar(250);index"` // 第三方id,不一定有/ song id\ Task id |
There was a problem hiding this comment.
Database migration required for existing installations.
This GORM model change updates the schema definition but does not automatically alter existing database tables. Deployments with existing data will encounter MySQL Error 1406 until the column is manually resized.
Consider providing a migration script or documenting the required ALTER TABLE command for operators.
📝 Example migration command
ALTER TABLE tasks MODIFY COLUMN task_id VARCHAR(250);Note: The exact table name should match your GORM configuration.
🤖 Prompt for AI Agents
In model/task.go around line 46, the struct tag change to
`gorm:"type:varchar(250);index"` requires a database migration for existing
installations to avoid MySQL Error 1406; add a migration step (or document it)
that runs an ALTER TABLE to modify the column size, e.g. ALTER TABLE tasks
MODIFY COLUMN task_id VARCHAR(250); and include the migration file or
instructions in the deployment docs and your migration tooling
(golang-migrate/liquibase/your choice) so deployments run the schema change
before this release.
|
上面那个ai也给你提示了,这个是不能改的。 |
Vertex AI Veo 3.1 returns task_id values that can exceed 191 characters. Increase the column length to 250 to accommodate these longer IDs.
Fixes #2417
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.