Skip to content

fix: volcengine && baidu claude adapter - #2294

Merged
Calcium-Ion merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/adapter-missing
Nov 25, 2025
Merged

fix: volcengine && baidu claude adapter#2294
Calcium-Ion merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/adapter-missing

Conversation

@seefs001

@seefs001 seefs001 commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Updated Claude request routing in Baidu and Volcengine channels to use dedicated Claude adaptor, improving request handling consistency and reliability across supported channels.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Two channel adaptors (Baidu v2 and Volcengine) are updated to delegate Claude request conversion to a dedicated Claude adaptor instead of the OpenAI adaptor, improving separation of concerns and consolidating Claude-specific logic.

Changes

Cohort / File(s) Summary
Channel adaptors migrating Claude handling
relay/channel/baidu_v2/adaptor.go, relay/channel/volcengine/adaptor.go
Added claude package import; modified ConvertClaudeRequest to instantiate and delegate to claude.Adaptor instead of openai.Adaptor for Claude request processing

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Both changes follow an identical, repetitive pattern (homogeneous refactoring)
  • Simple adaptor instantiation swaps with no underlying logic changes
  • No exported API signature modifications

Possibly related PRs

Suggested reviewers

  • Calcium-Ion

Poem

🐰 A Claude walks in, no more through OpenAI's door,
Now adaptors stand alone, each handling their core,
Baidu and Volcengine align the way,
Cleaner delegation brightens the day! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3d5fbd and e5e3e0f.

📒 Files selected for processing (2)
  • relay/channel/baidu_v2/adaptor.go (2 hunks)
  • relay/channel/volcengine/adaptor.go (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Calcium-Ion
Calcium-Ion merged commit 393c2b6 into QuantumNous:main Nov 25, 2025
1 check was pending
ennnnny pushed a commit to ennnnny/new-api that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants