feat: Add Vietnamese language support - #2268
Conversation
WalkthroughThe pull request adds Vietnamese language support to the application by introducing a new Vietnamese language option in the LanguageSelector component and registering the corresponding Vietnamese translations in the i18n configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
web/src/components/layout/headerbar/LanguageSelector.jsx (2)
23-59: Update the JP inline comment to reflect current implementationThe comment about the Japanese flag using an emoji fallback and JP not being exported is now outdated since the component imports and renders
<JP />. Consider updating or removing that comment to avoid confusion.
31-31: Vietnamese option is correctly wired; consider refreshing the sorting commentThe new Vietnamese dropdown item correctly uses the
'vi'code, matches the existing styling/active-state pattern, and uses theVNflag component, so behavior should be consistent with other languages. The “Language sorting” comment above still lists only the original set of languages; you might want to include Vietnamese there or reword it to stay accurate.Also applies to: 68-74
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
web/src/components/layout/headerbar/LanguageSelector.jsx(2 hunks)web/src/i18n/i18n.js(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
web/src/components/layout/headerbar/LanguageSelector.jsx (1)
web/src/hooks/common/useHeaderBar.js (1)
currentLang(39-39)
🔇 Additional comments (1)
web/src/i18n/i18n.js (1)
29-42: Vietnamese i18n resource wiring is consistentThe new
viTranslationimport andviresource entry match the existing pattern for other locales and align with the'vi'language code used in the UI. No issues from this file’s side.
feat: Add Vietnamese language support
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.