fix(channel): update channel identification logic in error processing

[NoahCodeGG]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for channel management to ensure channels are properly evaluated for disabling when errors occur.

[coderabbitai]

Walkthrough

A single parameter modification in the processChannelError function where channelError.ChannelId is replaced with channelError.ChannelType when invoking service.ShouldDisableChannel to evaluate channel disable conditions.

Changes

Cohort / File(s)	Summary
Channel error evaluation update controller/relay.go	Modified processChannelError to pass channelError.ChannelType instead of channelError.ChannelId to service.ShouldDisableChannel when determining whether to asynchronously disable a channel

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Key focus area: Verify the semantic correctness of using ChannelType instead of ChannelId for the disable evaluation logic
• Confirm this change aligns with the intended behavior of service.ShouldDisableChannel and its expectations
• Ensure no other call sites in the codebase depend on the previous parameter

Poem

🐰 A channel's ID transformed to Type,
One line adjusted, changes deep,
Error handling refined with care,
The relay now disables fair! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating channel identification logic in error processing by switching from ChannelId to ChannelType in the processChannelError function.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e082268 and 138810f.

📒 Files selected for processing (1)

• controller/relay.go (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

controller/relay.go (1)

service/channel.go (1)

• ShouldDisableChannel (47-99)

🔇 Additional comments (1)

controller/relay.go (1)

288-288: Fix is correct - all calls to ShouldDisableChannel pass the correct parameter type.

Verification confirms that the change at line 288 correctly passes channelError.ChannelType instead of the channel ID. All call sites in the codebase (including test code) correctly pass channel type values to ShouldDisableChannel, not channel IDs.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}