Skip to content

feat: topUp show correct symbol - #2111

Merged
seefs001 merged 1 commit into
QuantumNous:mainfrom
feitianbubu:pr/top-up-show-correct-symbol
Oct 28, 2025
Merged

feat: topUp show correct symbol#2111
seefs001 merged 1 commit into
QuantumNous:mainfrom
feitianbubu:pr/top-up-show-correct-symbol

Conversation

@feitianbubu

@feitianbubu feitianbubu commented Oct 27, 2025

Copy link
Copy Markdown
Member

充值显示的货币符号根据配置显示正确的符号
image

Summary by CodeRabbit

  • Bug Fixes
    • Fixed the recharge card to display currency-specific monetary values with proper currency symbol placement, replacing the previously shown generic preset amounts.

@coderabbitai

coderabbitai Bot commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The RechargeCard component's monetary display was updated to use displayValue instead of preset.value, now showing currency-specific converted amounts alongside currency symbols rather than raw preset values with fixed dollar signs.

Changes

Cohort / File(s) Summary
Topup Display Update
web/src/components/topup/RechargeCard.jsx
Changed monetary value display from preset.value to displayValue, with currency symbol appended to reflect type-specific conversions

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that displayValue is properly defined and sourced (check prop passing and calculation logic)
  • Confirm currency symbol handling is consistent across all preset types
  • Test rendering with different currency/preset combinations to ensure values display correctly

Poem

🐰 A rabbit hops through preset rows,
Where currency now freely flows,
From preset.value to displayValue's art,
Each symbol shows its special part,
Conversions bloom—pure and bright! 💚

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "feat: topUp show correct symbol" directly and accurately reflects the primary change in this pull request. The modification specifically updates the RechargeCard component to display the correct currency symbol based on configuration instead of using a hardcoded value. The title is concise, uses conventional commit format, and is specific enough that a teammate reviewing the history would understand this involves displaying the appropriate currency symbol for the top-up feature. The title avoids vague terminology and is clearly related to the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6791eb7 and 45ebcd4.

📒 Files selected for processing (1)
  • web/src/components/topup/RechargeCard.jsx (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
web/src/components/topup/RechargeCard.jsx (3)
web/src/components/topup/index.jsx (1)
  • formatLargeNumber (515-517)
web/src/helpers/render.jsx (4)
  • symbol (846-846)
  • symbol (916-916)
  • symbol (936-936)
  • symbol (980-980)
web/src/helpers/utils.jsx (1)
  • symbol (649-649)
🔇 Additional comments (1)
web/src/components/topup/RechargeCard.jsx (1)

450-450: LGTM! Correct currency display implementation.

The change properly displays the currency-converted amount with the correct symbol from configuration. This is consistent with how the currency symbol is already used for prices on lines 470-474, and correctly implements the PR objective to show the appropriate currency symbol based on configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seefs001
seefs001 merged commit 47bfea1 into QuantumNous:main Oct 28, 2025
1 check passed
ennnnny pushed a commit to ennnnny/new-api that referenced this pull request Mar 17, 2026
…orrect-symbol

feat: topUp show correct symbol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants