Skip to content

fix: empty version - #2024

Merged
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/version
Oct 12, 2025
Merged

fix: empty version#2024
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/version

Conversation

@seefs001

@seefs001 seefs001 commented Oct 12, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflow for ARM64 Docker image builds by adjusting how the release tag is resolved and exported to the environment. This streamlines the pipeline without altering build outputs. No user-facing functionality is changed, and application behavior remains the same. Process order adjusted; version file and build message remain unaffected.

@coderabbitai

coderabbitai Bot commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

The GitHub Actions workflow .github/workflows/docker-image-arm64.yml updates the “Resolve tag & write VERSION” step to compute TAG in a variable first, export it, and then proceed with writing VERSION and the build message. Overall workflow behavior remains the same.

Changes

Cohort / File(s) Summary
CI workflow: tag resolution/export
\.github/workflows/docker-image-arm64.yml
Adjusts the “Resolve tag & write VERSION” step: computes TAG into a variable, then exports it to the environment before writing VERSION. Command order changes; functional outcome (TAG available in env, VERSION file produced) remains equivalent.

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Actions Runner
    participant Sh as Shell Step
    participant Env as $GITHUB_ENV

    GH->>Sh: Run "Resolve tag & write VERSION"
    Sh->>Sh: Compute TAG
    Sh->>Env: export TAG=...
    Sh->>Sh: Write VERSION file
    Sh-->>GH: Step complete
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • feat: matrix ci #2014: Also changes TAG computation/export and VERSION writing in the same ARM64 Docker workflow step.
  • feat: matrix ci #2008: Similar edits to the “Resolve tag & write VERSION” step, adjusting how TAG/VERSION are derived and exported.

Poem

I nibble tags with whiskered grace,
Compute, export—no time to waste.
A VERSION nib—crisp, concise—
In YAML gardens, everything’s nice.
Hop, build, hop! The pipeline sings,
My paws commit the smallest things. 🐇🚀

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ede47ef and d2546cf.

📒 Files selected for processing (1)
  • .github/workflows/docker-image-arm64.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seefs001
seefs001 merged commit e5dde67 into QuantumNous:main Oct 12, 2025
1 check was pending
ennnnny pushed a commit to ennnnny/new-api that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant