Skip to content

fix: version - #2023

Merged
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/version
Oct 12, 2025
Merged

fix: version#2023
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/version

Conversation

@seefs001

@seefs001 seefs001 commented Oct 12, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where the application version could appear as unknown or incorrect by correcting how version information is embedded during builds.
  • Chores
    • Updated build configuration to reliably embed version metadata in release artifacts, with no impact on runtime functionality.

@coderabbitai

coderabbitai Bot commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Updated the Go linker -X flag in the Dockerfile to use the fully qualified path github.com/QuantumNous/new-api/common.Version instead of new-api/common.Version for embedding the Version variable at link time. No other build steps were modified.

Changes

Cohort / File(s) Summary of changes
Build & packaging
Dockerfile
Adjusted go build linker flag: -X target changed to github.com/QuantumNous/new-api/common.Version from new-api/common.Version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudge the flags with whiskered care,
A path made long from short to fair;
Version tucked where links reside,
In modules deep, I hop with pride.
Thump-thump—release will run just right,
Carrots cached, the build is light. 🥕

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5aaee9 and 0baacb2.

📒 Files selected for processing (1)
  • Dockerfile (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seefs001
seefs001 merged commit 6c77952 into QuantumNous:main Oct 12, 2025
1 check was pending
ennnnny pushed a commit to ennnnny/new-api that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant