Skip to content

fix env GHCR_REPOSITORY - #2016

Merged
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/ci-env
Oct 11, 2025
Merged

fix env GHCR_REPOSITORY#2016
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/ci-env

Conversation

@seefs001

@seefs001 seefs001 commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Normalize container registry repository naming in ARM64 image build and manifest jobs to ensure consistency across steps and reduce case-sensitivity issues during publishing.
    • Improves reliability of Docker authentication and multi-architecture manifest creation for ARM64 images; no functional changes to the app.
    • Streamlines release workflow for ARM64 containers, helping prevent tag publication failures and ensuring images are available as expected.

@seefs001
seefs001 merged commit 2d3fd56 into QuantumNous:main Oct 11, 2025
@coderabbitai

coderabbitai Bot commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a “Normalize GHCR repository” step in two jobs of .github/workflows/docker-image-arm64.yml to compute and export GHCR_REPOSITORY by lowercasing GITHUB_REPOSITORY, positioned after tag resolution/extraction. No other logic changes.

Changes

Cohort / File(s) Summary of changes
Workflow: Docker ARM64 image
\.github/workflows/docker-image-arm64.yml
Inserted a “Normalize GHCR repository” step in jobs build_single_arch (after resolving tag) and create_manifests (after extracting tag) to set GHCR_REPOSITORY as lowercased GITHUB_REPOSITORY for subsequent Docker auth and manifest operations.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Dev as GitHub Actions Runner
    participant B as build_single_arch Job
    participant M as create_manifests Job

    Note over B: Build single-arch image
    Dev->>B: Resolve tag
    B->>B: Normalize GHCR repository (lowercase GITHUB_REPOSITORY -> GHCR_REPOSITORY)
    B->>B: Docker login/build/push

    Note over M: Create multi-arch manifest
    Dev->>M: Extract tag
    M->>M: Normalize GHCR repository (lowercase GITHUB_REPOSITORY -> GHCR_REPOSITORY)
    M->>M: Docker login/manifest create & push
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • feat: matrix ci #2014 — Also modifies .github/workflows/docker-image-arm64.yml to add/normalize the GHCR_REPOSITORY environment variable, matching this change.

Poem

I hopped through YAML fields at night,
Lowercasing names by moonlit byte.
GHCR now knows where to go,
Tags resolved, the images flow.
With gentle paws, I press “commit” —
A tidy warren, workflows fit. 🐇🚀

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55afd5c and 5cfa648.

📒 Files selected for processing (1)
  • .github/workflows/docker-image-arm64.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot mentioned this pull request Oct 12, 2025
ennnnny pushed a commit to ennnnny/new-api that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant