fix: settings

[seefs001]

Summary by CodeRabbit

• Refactor

  • Unified system settings handling across worker requests, user notifications, and webhooks for consistency.
  • Standardized enablement checks and key validation to reduce configuration drift.
  • Streamlined internal configuration references without altering workflows.

• Chores

  • General cleanup to improve maintainability and reduce duplication.

• Notes

  • No user-facing behavior changes expected.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors three service files to use the system_setting package instead of setting. All references to worker-related configuration (EnableWorker, WorkerUrl, WorkerValidKey, WorkerAllowHttpImageRequestEnabled) are updated accordingly. No functional logic, signatures, or public APIs are changed.

Changes

Cohort / File(s)	Summary
Settings import refactor service/cf_worker.go, service/user_notify.go, service/webhook.go	Replace import one-api/setting with one-api/setting/system_setting and update all references: EnableWorker(), WorkerUrl, WorkerValidKey, WorkerAllowHttpImageRequestEnabled. No other logic or signatures changed.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Svc as Service (cf_worker/user_notify/webhook)
  participant Sys as system_setting
  participant Wkr as Worker Proxy
  participant Ext as External Endpoint

  Svc->>Sys: EnableWorker()
  alt worker enabled
    Svc->>Wkr: POST request (uses WorkerUrl, WorkerValidKey)
    Wkr->>Ext: Forward request
    Ext-->>Wkr: Response
    Wkr-->>Svc: Response
  else direct path
    Svc->>Ext: Direct HTTP request
    Ext-->>Svc: Response
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Fix/veo3 #1795 — Similar refactor switching from setting to system_setting for shared configuration, including worker flags and URLs.

Poem

I tweaked the knobs behind the scene,
Hopped from setting to system_setting clean.
Keys in paw, URLs aligned,
Worker burrows well-defined.
With whiskers twitching, I declare:
Same paths, new warren, handled with care. 🐇✨

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d71f46 and 8563eaf.

📒 Files selected for processing (3)

• service/cf_worker.go (3 hunks)
• service/user_notify.go (2 hunks)
• service/webhook.go (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}