Update relay-claude.go

[QingyeSC]

优化claude messages接口启用思考时的参数设置

Summary by CodeRabbit

• Bug Fixes
  • Improved parameter handling for specific models to ensure compatibility and better response quality.

[coderabbitai]

Walkthrough

The update adjusts the handling of sampling parameters in the function that adapts OpenAI-style requests to Anthropic for models with names ending in "-thinking." Specifically, it sets TopP to 0.95 and removes TopK by setting it to nil, in accordance with Anthropic's requirements.

Changes

File(s)	Change Summary
relay/channel/claude/relay-claude.go	Modified logic to set TopP to 0.95 and remove TopK for "-thinking" models.

Poem

A tweak for the thinkers, precise and neat,
TopP now dances at point nine-five’s beat.
TopK is gone, nil in its place,
Anthropic’s rules, we now embrace.
Rabbits code with thoughtful flair—
Hopping forward, we prepare!

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

relay/channel/claude/relay-claude.go (1)

121-124: Parameter adjustments align with Anthropic's requirements for thinking models.

The changes correctly implement Anthropic's requirements by setting TopK to nil and TopP to 0.95 for thinking models. However, consider the following:

1. Hardcoded value: The TopP is hardcoded to 0.95. While this is within the acceptable range (0.95-1), it might not be optimal for all use cases.

2. User input override: The implementation overrides any user-provided TopP value without preserving or validating it, which could be unexpected behavior.

Consider enhancing the implementation to respect user preferences within acceptable bounds:

-		// Anthropic 要求去掉 top_k
-		claudeRequest.TopK = nil
-		//top_p值可以在0.95-1之间
-		claudeRequest.TopP = 0.95
+		// Anthropic 要求去掉 top_k
+		claudeRequest.TopK = nil
+		//top_p值可以在0.95-1之间
+		if claudeRequest.TopP < 0.95 {
+			claudeRequest.TopP = 0.95
+		}

This approach would preserve user-provided TopP values that are already within the acceptable range while ensuring compliance with Anthropic's requirements.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78fb457 and 5621755.

📒 Files selected for processing (1)

• relay/channel/claude/relay-claude.go (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: 9Ninety
PR: QuantumNous/new-api#1273
File: relay/channel/gemini/relay-gemini.go:97-116
Timestamp: 2025-06-21T03:37:41.726Z
Learning: In relay/channel/gemini/relay-gemini.go, the thinking budget calculation logic (including the MaxOutputTokens multiplication) was introduced in PR #1247. PR #1273 focused specifically on decoupling the thoughts summary feature from thinking budget settings and did not modify the existing thinking budget behavior.

relay/channel/claude/relay-claude.go (1)

Learnt from: 9Ninety
PR: QuantumNous/new-api#1273
File: relay/channel/gemini/relay-gemini.go:97-116
Timestamp: 2025-06-21T03:37:41.726Z
Learning: In relay/channel/gemini/relay-gemini.go, the thinking budget calculation logic (including the MaxOutputTokens multiplication) was introduced in PR #1247. PR #1273 focused specifically on decoupling the thoughts summary feature from thinking budget settings and did not modify the existing thinking budget behavior.