fix: page_size setting not taking effect on user management page

[feitianbubu]

用户管理每页条数设置不生效
因为使了c.BindQuery(pageInfo) 需要在结构体tag设置form才会生效
p也设置了form后, 也就不需要再通过strconv.Atoi(c.Query("p"))拿了

Summary by CodeRabbit

• Refactor
  • Improved handling of pagination query parameters for more reliable and consistent page and page size values.

[coderabbitai]

Walkthrough

The PageInfo struct in common/page_info.go was updated to include form tags for direct query parameter binding. The GetPageQuery function was simplified by removing manual parsing and compatibility logic, and the unused strconv import was deleted.

Changes

File(s)	Change Summary
common/page_info.go	Added form tags to PageInfo struct fields; removed strconv import; simplified page parsing logic

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    Client->>Server: HTTP request with query params (p, page_size)
    Server->>Server: Bind query params to PageInfo struct (using form tags)
    Server->>Server: If Page < 1, set Page = 1
    Server-->>Client: Processed response

Loading

Possibly related PRs

• feat: 优化分页组件 #1298: Refactored the PageInfo struct and introduced the original query binding and parsing logic, which is directly modified in this PR.

Poem

A hop and a skip, the code’s now more neat,
With form tags in structs, query binding’s a treat!
No more old parsing, no strconv in sight,
Page numbers set right, the logic is light.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 338e914 and ff4fc57.

📒 Files selected for processing (1)

• common/page_info.go (2 hunks)

🔇 Additional comments (2)

common/page_info.go (2)

8-11: LGTM! Form tags correctly added to enable query parameter binding.

The addition of form:"p" and form:"page_size" tags to the Page and PageSize fields respectively will allow c.BindQuery(pageInfo) to properly bind the query parameters. This directly addresses the issue described in the PR objectives where the page size setting wasn't taking effect.

---

48-48: Good simplification of the page validation logic.

The removal of manual parsing logic is appropriate since the form tags now enable automatic query parameter binding. The simplified approach of setting Page = 1 when it's less than 1 is cleaner and more maintainable than the previous manual parsing approach.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Calcium-Ion]

需要解决一下冲突