refactor: log params and channel params - #1338
Closed
xyfacai wants to merge 1 commit into
Closed
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces strong typing for channel settings by defining a new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant GinContext
participant Controller
participant Model
participant DTO
Client->>Controller: AddChannel/UpdateChannel (JSON)
Controller->>DTO: Bind JSON to ChannelSettings
Controller->>Model: channel.ValidateSettings()
alt Validation fails
Controller->>Client: Return error JSON
else Validation succeeds
Controller->>Model: Proceed with DB operations
end
sequenceDiagram
participant Service
participant Model
Service->>Model: RecordConsumeLog(userId, RecordConsumeLogParams)
Model->>Model: LogQuotaData using params
Model-->>Service: (async) Logging complete
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (19)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jiutubaba
pushed a commit
to jiutubaba/fx-api
that referenced
this pull request
May 17, 2026
…elect fix(admin): fix Safari system log select height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Refactor