Skip to content

feat: add placeholder for kling AccessKey and SecretKey - #1279

Merged
Calcium-Ion merged 2 commits into
QuantumNous:alphafrom
feitianbubu:add-kling-key-placeholder
Jun 21, 2025
Merged

feat: add placeholder for kling AccessKey and SecretKey#1279
Calcium-Ion merged 2 commits into
QuantumNous:alphafrom
feitianbubu:add-kling-key-placeholder

Conversation

@feitianbubu

@feitianbubu feitianbubu commented Jun 21, 2025

Copy link
Copy Markdown
Member

增加可灵密钥输入框placeholder

Summary by CodeRabbit

  • New Features
    • Added a new prompt guiding the secret input format to use AccessKey|SecretKey in the channel editing interface.
    • Updated the API key input format to use a pipe (|) separator for improved consistency and clarity.

@coderabbitai

coderabbitai Bot commented Jun 21, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

A new case for the value 50 was added to the type2secretPrompt function in EditChannel.js, specifying a custom prompt string for secret input formatting. The parsing logic of the API key string in TaskAdaptor.Init was updated to split by a pipe character (|) instead of a comma, reflecting a change in the expected format. No other logic or control flow was modified.

Changes

File Change Summary
web/src/pages/Channel/EditChannel.js Added a case for value 50 in type2secretPrompt to return a specific prompt string.
relay/channel/task/kling/adaptor.go Changed API key parsing in TaskAdaptor.Init and createJWTTokenWithKey from splitting by comma to splitting by pipe (`

Poem

A prompt for secrets, clear and neat,
Now guides the user where keys meet.
With fifty as the magic code,
The format’s shown, the path bestowed.
A pipe now splits the keys with grace,
In code and prompts, a better place! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0da83b and e4def06.

📒 Files selected for processing (1)
  • relay/channel/task/kling/adaptor.go (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • relay/channel/task/kling/adaptor.go
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
web/src/pages/Channel/EditChannel.js (2)

67-68: Inconsistent colon style in prompt string
Other cases use a fullwidth Chinese colon () without a space. For consistency, update to:

-case 50:
-  return '按照如下格式输入: AccessKey|SecretKey';
+case 50:
+  return '按照如下格式输入:AccessKey|SecretKey';

54-72: Consider using translation keys instead of hardcoded phrases
Refactor type2secretPrompt to return i18n keys (e.g. 'channel.prompt.kling_keys') and move the actual Chinese strings into your locale JSON. This will improve maintainability and enable easy localization.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf4700a and 44d20de.

📒 Files selected for processing (1)
  • web/src/pages/Channel/EditChannel.js (1 hunks)
🔇 Additional comments (2)
web/src/pages/Channel/EditChannel.js (2)

67-68: New placeholder case implemented correctly
The added case 50 returns the intended AccessKey|SecretKey prompt, fulfilling the PR objective.


579-581: Ensure translation entry for dynamic prompt
Since you wrap the output of type2secretPrompt in t(), add the new string '按照如下格式输入:AccessKey|SecretKey' to your i18n locale files. Otherwise, t() will simply return the key itself.

@feitianbubu
feitianbubu force-pushed the add-kling-key-placeholder branch from a0da83b to e4def06 Compare June 21, 2025 13:38
@Calcium-Ion
Calcium-Ion changed the base branch from main to alpha June 21, 2025 16:45
@Calcium-Ion
Calcium-Ion merged commit ee8956b into QuantumNous:alpha Jun 21, 2025
x22x22 pushed a commit to x22x22/new-api that referenced this pull request Apr 24, 2026
…aceholder

feat: add placeholder for kling AccessKey and SecretKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants