Merged
Conversation
kshyatt
previously approved these changes
Jan 17, 2026
kshyatt
previously approved these changes
Jan 17, 2026
Codecov Report❌ Patch coverage is
... and 21 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Jutho
reviewed
Jan 17, 2026
| @@ -0,0 +1,7 @@ | |||
| function Mooncake.arrayify(A_dA::CoDual{<:TensorMap}) | |||
Member
There was a problem hiding this comment.
Was there a benefit to overloading arrayify versus just making a TensorKit specific function tensorify?
Jutho
reviewed
Jan 17, 2026
| A = Mooncake.primal(A_dA) | ||
| dA_fw = Mooncake.tangent(A_dA) | ||
| data = dA_fw.data.data | ||
| dA = typeof(A)(data, A.space) |
Member
There was a problem hiding this comment.
Also does this work in the complex case, where data is now probably using Mooncake's wonderful complex Complex tangent type?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up the structure for beginning to deal with Mooncake in TensorKit.
I think we should merge this like it is ASAP so we can in parallel start working on: