avoid twist allocating in rrules when not required#306
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
|
I think there's two more in the |
Member
Author
|
Unfortunately, the non-passing tests seem to be unrelated. I still haven't figured out a good way to make testing truncated SVD compatible with finite-difference checks, since this more or less requires that the variations are small enough that the truncation selects the same subspace every time. |
Jutho
reviewed
Oct 27, 2025
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Jutho
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary non-breaking solution before #305 fully resolves the issue, to already include in a patch release.
@leburgel tagging you here