Closed
Conversation
Member
|
I'm sorry, I should have let you know that I already have some local progress for this. It's not pushed since TensorKitmanifolds wasn't tagged... |
Member
Author
|
Don't worry lol it was like 5 minutes of work |
Member
|
I'll push when I get to the office, but tldr I think we can delete that code entirely since I introduced that before the orthnull rewrite to temporarily patch that, which is now just handled by the base implementation |
Member
|
Will close this as it is superseded by #365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw an error deeper in the quasiparticle tests locally, let's see how this goes. I would also like to update this utility code to be GPU friendly in advance :)