Define GeometryStyle and OperatorStyle for multiple arguments#354
Merged
lkdvos merged 8 commits intoQuantumKitHub:mainfrom Nov 19, 2025
Merged
Define GeometryStyle and OperatorStyle for multiple arguments#354lkdvos merged 8 commits intoQuantumKitHub:mainfrom
GeometryStyle and OperatorStyle for multiple arguments#354lkdvos merged 8 commits intoQuantumKitHub:mainfrom
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Nov 18, 2025
Rephrase error messages based on Lukas' suggestion Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
approved these changes
Nov 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up some work to make it possible/easier to add custom state or operator types without having to alter their base implementations, and without having to redefine a bunch of functionality that already just works.
This PR defines standard promotion rules for the styles in the form of
GeometryStyle(x, y, zs...)andOperatorStyle(x, y, zs...)by recursively comparing the styles of the objects.
An example, where this is needed, are
environments(below, operator, above).This PR allows to extract and validate the common
GeometryStyleby calling:GeometryStyle(below, operator, above)