This repository has been archived by the owner on Apr 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Roger-luo
commented
Dec 8, 2019
•
edited
Loading
edited
- transform -> hcphases
Also need to update readme. |
wangleiphy
suggested changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, a typo in readme, trivil -> trivial
since with julia> @benchmark apply!($(copy(reg)), block_iqft)
BenchmarkTools.Trial:
memory estimate: 6.95 KiB
allocs estimate: 75
--------------
minimum time: 7.748 μs (0.00% GC)
median time: 8.948 μs (0.00% GC)
mean time: 11.002 μs (4.54% GC)
maximum time: 4.349 ms (39.70% GC)
--------------
samples: 10000
evals/sample: 3 and using inplace
I'll remove this and we should just use |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=========================================
+ Coverage 78.1% 80.61% +2.5%
=========================================
Files 28 28
Lines 571 557 -14
=========================================
+ Hits 446 449 +3
+ Misses 125 108 -17
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.