Skip to content
This repository has been archived by the owner on Apr 30, 2022. It is now read-only.

rename & add doc #18

Merged
merged 12 commits into from
Dec 12, 2019
Merged

rename & add doc #18

merged 12 commits into from
Dec 12, 2019

Conversation

Roger-luo
Copy link
Member

@Roger-luo Roger-luo commented Dec 8, 2019

  • transform -> hcphases

@wangleiphy
Copy link
Contributor

Also need to update readme.
It contains QFTCircuit(n): construct a quantum fourier transformation circuit.

Copy link
Contributor

@wangleiphy wangleiphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, a typo in readme, trivil -> trivial

@Roger-luo
Copy link
Member Author

since reorder_firstdim is slower and not well maintained

with reorder_firstdim

julia> @benchmark apply!($(copy(reg)), block_iqft)
BenchmarkTools.Trial:
  memory estimate:  6.95 KiB
  allocs estimate:  75
  --------------
  minimum time:     7.748 μs (0.00% GC)
  median time:      8.948 μs (0.00% GC)
  mean time:        11.002 μs (4.54% GC)
  maximum time:     4.349 ms (39.70% GC)
  --------------
  samples:          10000
  evals/sample:     3

and using inplace reorder!

julia> @benchmark apply!($(copy(reg)), block_iqft)
BenchmarkTools.Trial:
  memory estimate:  4.03 KiB
  allocs estimate:  44
  --------------
  minimum time:     6.759 μs (0.00% GC)
  median time:      7.775 μs (0.00% GC)
  mean time:        9.375 μs (3.90% GC)
  maximum time:     4.170 ms (28.98% GC)
  --------------
  samples:          10000
  evals/sample:     4

I'll remove this and we should just use invorder!

@Roger-luo Roger-luo requested a review from GiggleLiu December 12, 2019 05:42
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #18 into master will increase coverage by 2.5%.
The diff coverage is 59.67%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #18     +/-   ##
=========================================
+ Coverage    78.1%   80.61%   +2.5%     
=========================================
  Files          28       28             
  Lines         571      557     -14     
=========================================
+ Hits          446      449      +3     
+ Misses        125      108     -17
Impacted Files Coverage Δ
src/block_extension/reflect_gate.jl 100% <ø> (ø) ⬆️
src/diff_extension/stats.jl 88.46% <ø> (ø) ⬆️
src/diff_extension/kernel_mmd.jl 92% <ø> (ø) ⬆️
src/Miscellaneous.jl 0% <ø> (-38.89%) ⬇️
src/block_extension/math_gate.jl 94.73% <ø> (ø) ⬆️
src/YaoExtensions.jl 100% <ø> (ø) ⬆️
src/block_extension/FSimGate.jl 44.44% <0%> (ø) ⬆️
src/block_extension/TrivilGate.jl 62.5% <0%> (ø) ⬆️
src/block_extension/sequence.jl 52.63% <0%> (ø) ⬆️
src/block_extension/Mod.jl 88.88% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebeca79...89c71cf. Read the comment docs.

@GiggleLiu GiggleLiu merged commit 8dbbec0 into master Dec 12, 2019
@Roger-luo Roger-luo deleted the rename-qft branch December 12, 2019 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants