ci: Update uv.lock on release-please PRs#870
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 74 74
Lines 8786 8786
=======================================
Hits 8188 8188
Misses 598 598 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ss2165
left a comment
There was a problem hiding this comment.
pls wait for release before merging (I know it shouldn't matter but paranoia)
|
I wasn't expecting astral-sh/uv#12235 to break any existing workflows or require manual edits to |
|
@konstin Hi! Sorry for the noisy back-links. The workflow here is running googleapis/release-please to automatically create release PRs with including changelog entries and bumped package versions. The version update logic is quite simple, and manually edits the version in a couple pre-determined places ( I rolled back this change in a fork and updated uv to show the error. Note that the check workflow only fails if we run |
See guppy PR for more detailed info: Quantinuum/guppylang#870
See guppy PR for more detailed info: Quantinuum/guppylang#870
uv 0.6.6adds a hard error when the version of the package inuv.lockdoes not match the one declared in the editable wheel: astral-sh/uv#12235.release-pleasedoesn't update the lock files automatically, so release PRs needed a manual lock update.This PR adds the lockfile as an
extra-file, to avoid this manual step.Note that the jsonpath in the config is not technically correct, as release-please's json array filters don't quite work for toml files. See googleapis/release-please#2455, which includes this hacky workaround.