-
Notifications
You must be signed in to change notification settings - Fork 3
Fix a bug with the current implementation of the NumericPercentile
Constraint
#241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 93.35% 93.36% +0.01%
==========================================
Files 18 18
Lines 1985 1988 +3
==========================================
+ Hits 1853 1856 +3
Misses 132 132 ☔ View full report in Codecov by Sentry. |
NumericPercentile
Constraint
NumericPercentile
Constraint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you plan on releasing right away you can fix the changelog file before merging.
Previously, the percentile computation was not according to the definition we provided ourselves.
Our definition said that
Let's now assume we have the following data
If we set the percentile of interest to be 20%, we see that the value 4 is the smallest value present in the data, for which at least 20% of the data is lesser or equal to that value.
Previously, our retrieval would've yielded 3. This behavior is explicitly reflected in our own tests.