Fix two minor errors in docs #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 93.76% 93.76%
=======================================
Files 18 18
Lines 1894 1894
=======================================
Hits 1776 1776
Misses 118 118 ☔ View full report in Codecov by Sentry. |
|
@kklein Can I merge despite the failed test on code coverage? |
|
@MariusMerkleQC yes. |
Yes - it was only temporarily failing since not all integration tests had run through yet. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I'd like to adjust the "Example: Dates" documentation. The date ranges' upper bound should go until the end of January (
upper_bound="20220131"), rather than the beginning of January (upper_bound="20220101") to which it is set currently.