Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install jupyterlab before npm build #19

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

davidbrochart
Copy link
Member

@davidbrochart davidbrochart commented Oct 22, 2024

check_release failed because jlpm could not be found, and since yjs-widgets is a JupyterLab extension it seems reasonable to add it as a dependency.

@davidbrochart davidbrochart marked this pull request as draft October 22, 2024 18:04
@davidbrochart davidbrochart marked this pull request as ready for review October 22, 2024 18:12
@jtpio
Copy link
Member

jtpio commented Oct 22, 2024

A better way would be to install jupyterlab via a releaser hook instead, similar to the extension template:

https://github.com/jupyterlab/extension-template/blob/5696924f5b7adf07cf07ea9d3510c66914fbb770/template/pyproject.toml.jinja#L81-L87

That way yjs-widgets may have a chance to work in JupyterLite if we can avoid adding the dependency on jupyterlab.

@davidbrochart
Copy link
Member Author

Thanks, I suspected there was a better way.

@davidbrochart davidbrochart changed the title Add jupyterlab dependency Install jupyterlab before npm build Oct 22, 2024
@davidbrochart davidbrochart merged commit 85f9f49 into QuantStack:main Oct 22, 2024
3 checks passed
@davidbrochart davidbrochart deleted the deps branch October 22, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants