feat(client): Add ThemeManager for grid #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AntoinePrv
reviewed
Dec 9, 2025
| await widget.content.ready; | ||
| widget.content.style = style; | ||
| widget.content.rendererConfig = rendererConfig; | ||
| updateThemes(); |
Member
There was a problem hiding this comment.
Is it valid to call updateThemes here even though it is defined after?
Contributor
Author
There was a problem hiding this comment.
If your question is about whether it is valid of calling updateThemes function here, then the answer is yes. This method does not run at the moment the widgetCreated callback is registered. When this callback runs, updateThemes has been defined in memory.
Member
|
Good job, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ThemeManager. The task is #1
The result:
Screencast from 2025-12-09 13-54-54.webm