Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Nov 25, 2025

Overview

This PR tests the preview of the modernized from QuantEcon/quantecon-book-theme#335

Changes

  • Updates to install theme from branch
  • Enables CI preview build with the updated theme

Theme Updates (PR #335)

Security & Dependencies

  • ✅ Fixed npm vulnerabilities (cross-spawn, nanoid)
  • ✅ Added SRI hashes to CDN scripts
  • ✅ Updated Node.js from 16.13.2 (EOL) to 18.18.0 LTS
  • ✅ Updated all npm dependencies to latest versions

Code Organization

  • ✅ Modularized SCSS: 2038 lines → 11 focused modules
  • ✅ Modularized JavaScript: 565 lines → 8 focused modules
  • ✅ JS bundle reduced from 8.91 KiB to 8.73 KiB

Performance

  • ✅ Added preconnect hints for faster CDN loading (~100-300ms improvement)

Testing

  • ✅ Increased from 13 to 23 tests (77% increase)
  • ✅ Fixed all deprecation warnings (19 → 0)
  • ✅ Zero security vulnerabilities

Preview

Once CI completes, a Netlify preview will be available to test the visual appearance and functionality with the updated theme.

Expected Outcome

The site should look identical to the current version while benefiting from improved security, maintainability, and performance.

- Switch from version 0.13.0 to technical-review-nov2025 branch
- This enables preview of modernization and security updates
- Includes Node.js update, dependency updates, and code organization improvements
@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-740--sunny-cactus-210e3e.netlify.app (e245cf0)

@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-740--sunny-cactus-210e3e.netlify.app (3aab49d)

@mmcky
Copy link
Contributor Author

mmcky commented Nov 26, 2025

Theme Preview Regression Check ✅

Compared the Netlify preview build against the live site at python.quantecon.org to verify the theme refactor (PR #335) introduces no visual regressions.

Pages Tested

Page Status
Introduction (intro.html) ✅ Pass
Finite Markov Chains (#34) ✅ Pass
Wealth Distribution Dynamics (#39) ✅ Pass
Kalman Filter (#40) ✅ Pass
McCall Search Model (#42) ✅ Pass

Elements Verified

Element Result
Code blocks + copy button ✅ Identical
Matplotlib figures ✅ Same rendering
Math equations (inline & block) ✅ Correct
Numbered equations ✅ Same format
Collapsible solutions ✅ Working
Code warnings (⚠️ admonitions) ✅ Displays
Sidebar navigation (91 lectures) ✅ Complete
External links (QuantEcon, Wikipedia) ✅ Working
Internal cross-references ✅ Working
Footnotes ✅ Clickable
Footer (CC license, theme credit) ✅ Present

Conclusion

No regressions detected. The theme refactor maintains full visual and functional parity with the production site. Safe to merge once upstream PR #335 is ready.

@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-740--sunny-cactus-210e3e.netlify.app (1cc75f3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants