-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add njit interpolation functions #724
Conversation
Hello @mmcky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-03-04 00:48:39 UTC |
|
thanks @oyamad probably not -- i didn't realise it was supported. As we have decided to revert the order of arguments to match the numpy order we should use the numba built-in. |
cc @jstac |
Thanks @mmcky heading to the hospital now. |
Thanks @oyamad . Sorry @mmcky , my bad. perhaps we can test if swapping for the numpy version degrades performance or causes any issues in one or two lectures that are currently using jitted functions plus the version from |
This PR adds the following interpolation functions
interp
that accepts x asfloat
ornp.array
and the following internal functions:
_interpf
that accepts x asfloat
_interpa
that accepts x asnp.array