Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update license file from BSD-3 to MIT #712

Merged
merged 1 commit into from
Jul 12, 2023
Merged

FIX: Update license file from BSD-3 to MIT #712

merged 1 commit into from
Jul 12, 2023

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Jul 6, 2023

This PR updates the license to MIT

@coveralls
Copy link

coveralls commented Jul 6, 2023

Coverage Status

coverage: 93.024% (+0.009%) from 93.015% when pulling a924c03 on update-license into 8dbd7b2 on main.

@mmcky
Copy link
Contributor Author

mmcky commented Jul 6, 2023

@jstac @oyamad @thomassargent30 this is a change in LICENSE so I wanted to seek approval from all lead developers for this change. Thank you.

@oyamad
Copy link
Member

oyamad commented Jul 6, 2023

@mmcky I have no preference between BSD-3 and MIT, but just wondered why we change the LICENSE rather than the description in the paper?

@mmcky
Copy link
Contributor Author

mmcky commented Jul 6, 2023

@oyamad good question. @jstac do you have a preference between MIT and BSD-3?
I see more projects going to MIT perhaps because the license is slightly simpler.

@jstac
Copy link
Contributor

jstac commented Jul 6, 2023

@mmcky @oyamad I hear that MIT is simpler and more popular. I would be happy to see the change but I don't have strong opinions. Please feel free to make the call.

@jstac
Copy link
Contributor

jstac commented Jul 6, 2023

To be clear, @mmcky and @oyamad are joint maintainers and so have the final say. Since @oyamad has no objection, it seems fine to merge...?

@mmcky
Copy link
Contributor Author

mmcky commented Jul 12, 2023

thanks @oyamad and @jstac appreciate the discussion around license. I will merge this now and move to MIT.

@mmcky mmcky merged commit b8e0abc into main Jul 12, 2023
10 checks passed
@mmcky mmcky deleted the update-license branch July 12, 2023 05:53
@mmcky mmcky restored the update-license branch July 12, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants