Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLOG] add stdlib/lapack blog post #886

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

[BLOG] add stdlib/lapack blog post #886

wants to merge 14 commits into from

Conversation

Pranavchiku
Copy link

@Pranavchiku Pranavchiku commented Sep 21, 2024 •
edited
Loading

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • Blog post featured image is in PNG or JPEG format, not SVG.
  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

@vercel Vercel
Copy link

vercel bot commented Sep 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
labs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 4:57am

@Pranavchiku Pranavchiku marked this pull request as draft September 21, 2024 15:19
@Pranavchiku
Copy link
Author

I'll apply the code review by tomorrow morning my time ( IST ), it is midnight 12 right now :)

Pranavchiku
Pranavchiku commented Oct 2, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
Pranavchiku
Pranavchiku commented Oct 2, 2024
View reviewed changes
apps/labs/posts/implement-lapack-routines-in-stdlib.md
---
title: "Adding support for LAPACK routines in stdlib"
authors: [pranav-goswami]
published: September 30, 2024
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date change required

Pranavchiku
Pranavchiku commented Oct 2, 2024
View reviewed changes
apps/labs/posts/implement-lapack-routines-in-stdlib.md Outdated
Comment on lines 8 to 11
src: /posts/hello-world-post/featured.png
alt: "WIP"
hero:
imageSrc: /posts/hello-world-post/hero.jpeg
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte do you wish any specific images in here?

@Pranavchiku
Copy link
Author

I am not sure why deployment fails: https://vercel.com/quansight/labs/4A96Z9d5JKZxsjjUyUEnAa1ppwyZ?filter=errors. I am unable to find any explicit error which I can fix. Any suggestion will be very helpful :)

@melissawm
Copy link
Contributor

@Pranavchiku I just pushed a commit that should fix the deployment 😄

@Pranavchiku
Copy link
Author

Wohoo! Thank you Melissa :))

@Pranavchiku Pranavchiku marked this pull request as ready for review October 3, 2024 14:43
@gabalafou
Copy link
Contributor

I got a notification that I was added as a reviewer to this PR, is there something in particular you would like me to review or are you asking for a more general review?

@kgryte
Copy link
Member

kgryte commented Oct 3, 2024

@gabalafou I am not sure why you were pinged. I'll remove you. This PR is not ready for review yet.

@kgryte kgryte marked this pull request as draft October 3, 2024 15:40
@kgryte kgryte removed the request for review from gabalafou October 3, 2024 15:40
@Pranavchiku
Copy link
Author

@gabalafou I am not sure why you were pinged

plus, I think it was automatic.

@melissawm
Copy link
Contributor

Hi all - any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissawm melissawm melissawm left review comments

@kgryte kgryte kgryte left review comments

@pavithraes pavithraes Awaiting requested review from pavithraes pavithraes is a code owner

@trallard trallard Awaiting requested review from trallard trallard is a code owner

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

@gabalafou gabalafou Awaiting requested review from gabalafou gabalafou will be requested when the pull request is marked ready for review gabalafou is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pranavchiku @melissawm @gabalafou @kgryte