Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOG] Add metadsl.md #653

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[BLOG] Add metadsl.md #653

wants to merge 3 commits into from

Conversation

MarsBarLee
Copy link
Contributor

@MarsBarLee MarsBarLee commented Feb 7, 2023

Link to blog post, successful build.

Links to other Quansight blogs:

There is no need to check for Blog2Blog links due to updated website build.

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

@MarsBarLee MarsBarLee added labs 🔭 Items related to the Labs website type: content 📝 labels Feb 7, 2023
@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
consulting ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 10:52PM (UTC)
labs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 10:52PM (UTC)

Copy link
Contributor

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's not right.

The preview build of the blog post at this slug metadsl is actually showing the blog post at slug metadsl-talk.

Probably a bug in the blog post slug routing machinery.

@MarsBarLee
Copy link
Contributor Author

I've renamed the blog title from metadsl to metadsl-2019-05, following the solution suggested in #552. It now successfully directs to correct blog post, not metadsl-talk anymore.

Here's the built blog gallery and here's the built blog page itself.

Copy link
Contributor

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing this with the post on the old blog, I think it has the same issue that we are tracking in #679.

This doesn't look right to me. Here is a screenshot showing a portion of the blog post on the new site. Sandwiched between plain prose text, there is a code block and immediately following the code block, there is a single line, add(from_str('a'), from_str('b')), which should be formatted to look like the output from the code block, but to my eyes it looks like it is indistinguishable from the surrounding prose:

@MarsBarLee
Copy link
Contributor Author

@gabalafou You're right, that is a code output. I've added this PR to the tracking issue. Thanks for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labs 🔭 Items related to the Labs website type: content 📝
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants