Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOG] Spyder 2022 roadmap and new grants blog post #344

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

dalthviz
Copy link

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

Hi! I think the post is following the guidelines but any comment, suggestion or correction is greatly appreciated. Also, I'm not totally sure if adding images (the featureImage and hero images) is required but if that is the case let me know :)

@vercel
Copy link

vercel bot commented Jul 12, 2022

@dalthviz is attempting to deploy a commit to the Quansight Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
consulting ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 1:49PM (UTC)
labs ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 1:49PM (UTC)
quansight-labs-published ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 1:49PM (UTC)

@vercel vercel bot temporarily deployed to Preview – quansight-labs-published July 28, 2022 15:03 Inactive
Copy link
Contributor

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dalthviz , sorry it took us so long to get to this! We honestly didn't even see it until today because of all of the madness around getting the site off the ground for the SciPy conference.

I left some review comments. Many of them are minor corrections or suggestions for English grammar. Feel free to accept or ignore the suggestions wherever you think best. :)

The one possible blocker that we need to make a decision on is the lack of a hero image in the yaml top section. Without a hero image, the blog post does not quite render correctly.

It's not easy to see in the screenshot above but there is a little bump poking out from the bottom of the nav bar. That's the "Back to blog" link. It's hidden underneath the nav bar because the markup expects there to be a hero image.

I think we have two choices:

  1. Use one of the stock hero images. @noatamir can you chime in where Daniel can find those.
  2. Find something that can be used as a hero image specifically for this blog post.

It would also be nice to have a featured image because without it, the link to this post looks a little sad next to the other links that have images:

apps/labs/posts/spyder-roadmap-proposals-2022.md Outdated Show resolved Hide resolved
apps/labs/posts/spyder-roadmap-proposals-2022.md Outdated Show resolved Hide resolved
apps/labs/posts/spyder-roadmap-proposals-2022.md Outdated Show resolved Hide resolved
apps/labs/posts/spyder-roadmap-proposals-2022.md Outdated Show resolved Hide resolved
apps/labs/posts/spyder-roadmap-proposals-2022.md Outdated Show resolved Hide resolved
apps/labs/posts/spyder-roadmap-proposals-2022.md Outdated Show resolved Hide resolved

## Next steps

We will be focusing our time as a project on pushing forward the accepted proposals and submitting new ones. On top of this we will try to get more feedback about the things that volunteers, users and community in general want to see in the future for Spyder and share the proposals progress relaunching the [Spyder Community calls](https://github.com/spyder-ide/community#spyder-communitycalls).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence is a run-on. It's unclear to me what you mean. I think you're saying something like:

  • We are relaunching Spyder Community Calls.
  • The reasons we are relaunching these calls are
    1. to share the progress from the proposals and
    2. to gather feedback from the community

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep exactly! I will try to rephrase this to be more clear 👍🏼. Also, thank you so much for taking the time to review this! :)

@dalthviz dalthviz changed the title [BLOG] Spyder 2022 roadmap and new grants blog post [BLOG] Spyder 2022 roadmap and new grants blog post (WIP) Jul 28, 2022
@dalthviz
Copy link
Author

Thank you again @gabalafou for the review! Thinking about the featured and hero images could something like the Spyder logo (for the featured image) and banner (for the hero image) work?

spyder-title

spyder_readme_banner

@gabalafou
Copy link
Contributor

Those images seem fine to me, but I would like a second opinion from @noatamir.

@gabalafou
Copy link
Contributor

@dalthviz, there's additional guidance (see number 7) on these blog images in Notion.

@dalthviz dalthviz force-pushed the spyder-roadmap-proposals-blog branch from 05abfbd to ef61c32 Compare July 29, 2022 18:41
@dalthviz dalthviz changed the title [BLOG] Spyder 2022 roadmap and new grants blog post (WIP) [BLOG] Spyder 2022 roadmap and new grants blog post Jul 29, 2022
@noatamir
Copy link
Contributor

noatamir commented Aug 5, 2022

Those images seem fine to me, but I would like a second opinion from @noatamir.

LGTM

@noatamir
Copy link
Contributor

noatamir commented Aug 5, 2022

@gabalafou the images are the correct size, but they don't appear in the preview link.
I had a similar question on #406.
Is this ops related?

@trallard
Copy link
Member

Images are looking good and the content seems to be all good. @dalthviz @noatamir am I ok to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants