-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLOG] Spyder 2022 roadmap and new grants blog post #344
base: develop
Are you sure you want to change the base?
[BLOG] Spyder 2022 roadmap and new grants blog post #344
Conversation
@dalthviz is attempting to deploy a commit to the Quansight Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dalthviz , sorry it took us so long to get to this! We honestly didn't even see it until today because of all of the madness around getting the site off the ground for the SciPy conference.
I left some review comments. Many of them are minor corrections or suggestions for English grammar. Feel free to accept or ignore the suggestions wherever you think best. :)
The one possible blocker that we need to make a decision on is the lack of a hero image in the yaml top section. Without a hero image, the blog post does not quite render correctly.
It's not easy to see in the screenshot above but there is a little bump poking out from the bottom of the nav bar. That's the "Back to blog" link. It's hidden underneath the nav bar because the markup expects there to be a hero image.
I think we have two choices:
- Use one of the stock hero images. @noatamir can you chime in where Daniel can find those.
- Find something that can be used as a hero image specifically for this blog post.
It would also be nice to have a featured image because without it, the link to this post looks a little sad next to the other links that have images:
|
||
## Next steps | ||
|
||
We will be focusing our time as a project on pushing forward the accepted proposals and submitting new ones. On top of this we will try to get more feedback about the things that volunteers, users and community in general want to see in the future for Spyder and share the proposals progress relaunching the [Spyder Community calls](https://github.com/spyder-ide/community#spyder-communitycalls). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sentence is a run-on. It's unclear to me what you mean. I think you're saying something like:
- We are relaunching Spyder Community Calls.
- The reasons we are relaunching these calls are
- to share the progress from the proposals and
- to gather feedback from the community
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep exactly! I will try to rephrase this to be more clear 👍🏼. Also, thank you so much for taking the time to review this! :)
Thank you again @gabalafou for the review! Thinking about the featured and hero images could something like the Spyder logo (for the featured image) and banner (for the hero image) work? |
Those images seem fine to me, but I would like a second opinion from @noatamir. |
@dalthviz, there's additional guidance (see number 7) on these blog images in Notion. |
05abfbd
to
ef61c32
Compare
LGTM |
@gabalafou the images are the correct size, but they don't appear in the preview link. |
Text styling
Non-text contents
Hi! I think the post is following the guidelines but any comment, suggestion or correction is greatly appreciated. Also, I'm not totally sure if adding images (the
featureImage
andhero
images) is required but if that is the case let me know :)