Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Py39 test, accounting for lack of 3.9.0 tarball on travis #94

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

telamonian
Copy link
Contributor

This builds on/is an alternative to #92, and adds support for a working py3.9 test today (which, happily enough, already passes).

The python 3.9.0 tarball isn't available yet from travis, so this PR sidesteps the issue and sets an independent PYTHON_VERSION var (since the travis python install isn't actually used by the tests). If desired, in a few weeks when the travis people get around to building the 3.9.0 tarball, 72745ae can be reverted to make the config for the 3.9 travis job identical to the rest of the travis jobs, but it shouldn't make a difference

asmeurer and others added 2 commits October 22, 2020 07:07
This probably won't work yet because of missing conda packages, but we can
keep trying a rebuild and merge once it does.
@telamonian telamonian changed the title Py39 Add Py39 test, accounting for lack of 3.9.0 tarball on travis Oct 22, 2020
@scopatz
Copy link
Contributor

scopatz commented Oct 22, 2020

This looks fine to me. CC @asmeurer

@asmeurer
Copy link
Member

It's weird that the TESTS=true environment variable doesn't show up in the build list.

@asmeurer asmeurer merged commit 00d3aeb into Quansight-Labs:master Oct 23, 2020
@ericdatakelly ericdatakelly added this to the October 2020 milestone Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants