Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH - Move to hatch for dev/build #27

Merged
merged 35 commits into from
Apr 5, 2023
Merged

ENH - Move to hatch for dev/build #27

merged 35 commits into from
Apr 5, 2023

Conversation

trallard
Copy link
Member

@trallard trallard commented Apr 3, 2023 •
edited
Loading

This PR adds the following changes:

  • Changes to hatch for our build and dev
  • Adds GitHub workflows for building and publishing releases
  • Update documentation to reflect these changes
  • Add contrast tests (will be configured in a separate PR)
  • Use pathlib for path handling

TODO:

  • Add secrets needed by the workflows

@trallard trallard added the type: enhancement 💅🏼 New feature or request label Apr 3, 2023
@trallard
Copy link
Member Author

trallard commented Apr 3, 2023

I think this is ready for a review - there might be some bits I missed but can do another check tomorrow

steff456
steff456 suggested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests and a release GitHub action.

I just left one comment in the main readme, the rest looks good ✨

CONTRIBUTING.md Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 4, 2023 •
edited
Loading

PR Preview Action v1.2.0
🚀 Deployed preview to https://Quansight-Labs.github.io/accessible-pygments/pr-preview/pr-27/
on branch gh-pages at 2023-04-05 09:36 UTC

@trallard trallard merged commit d075e57 into main Apr 5, 2023
@trallard trallard deleted the trallard/hatch branch April 5, 2023 10:08
@steff456 steff456 mentioned this pull request Apr 5, 2023
Closed
@gabalafou gabalafou mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steff456 steff456 steff456 requested changes

Assignees
No one assigned
Labels
area: CI 👷🏽‍♀️ type: enhancement 💅🏼 New feature or request type: maintenance 🛠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trallard @steff456