Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcvl 791 add symmetric mzi and improve generic interferometer #462

Conversation

MarionQuandela
Copy link
Contributor

No description provided.

@MarionQuandela
Copy link
Contributor Author

Script to test this branch:

import perceval as pcvl

mzi_generator_func = pcvl.catalog['symmetric mzi'].generate
def upper_component_gen(idx: int):
    return pcvl.PS(phi=pcvl.Parameter(f"φ_upper_{idx}"))
def lower_component_gen(idx: int):
    return pcvl.PS(phi=pcvl.Parameter(f"φ_lower_{idx}"))

c = pcvl.GenericInterferometer(6, mzi_generator_func,
                               upper_component_gen=upper_component_gen, lower_component_gen=lower_component_gen)
pcvl.pdisplay(c)

@MarionQuandela MarionQuandela force-pushed the PCVL-791-add-symmetric-mzi-and-improve-generic-interferometer branch from 15b5c37 to 7f53a28 Compare September 12, 2024 14:53
perceval/components/core_catalog/mzi.py Show resolved Hide resolved
tests/test_generic_interferometer.py Show resolved Hide resolved
tests/test_generic_interferometer.py Outdated Show resolved Hide resolved
tests/test_generic_interferometer.py Show resolved Hide resolved
perceval/components/generic_interferometer.py Outdated Show resolved Hide resolved
tests/test_generic_interferometer.py Show resolved Hide resolved
perceval/components/generic_interferometer.py Show resolved Hide resolved
perceval/utils/algorithms/circuit_optimizer.py Outdated Show resolved Hide resolved
@MarionQuandela MarionQuandela force-pushed the PCVL-791-add-symmetric-mzi-and-improve-generic-interferometer branch from 4a2d277 to 7b326c1 Compare September 19, 2024 14:59
@MarionQuandela MarionQuandela changed the base branch from release/0.12.0 to release/0.11.2 September 19, 2024 15:00
@MarionQuandela MarionQuandela force-pushed the PCVL-791-add-symmetric-mzi-and-improve-generic-interferometer branch 2 times, most recently from 787a5ac to 4753033 Compare September 19, 2024 15:25
@MarionQuandela MarionQuandela force-pushed the PCVL-791-add-symmetric-mzi-and-improve-generic-interferometer branch from 4753033 to a8ab0bc Compare September 19, 2024 15:34
@ericbrts ericbrts merged commit f6958da into Quandela:release/0.11.2 Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants